[Qemu-devel] [7101] Skip KVM probe for OpenSolaris

[Qemu-devel] [7101] Skip KVM probe for OpenSolaris

[Blue Swirl]

Revision: 7101
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7101
Author:   blueswir1
Date:     2009-04-13 16:23:22 +0000 (Mon, 13 Apr 2009)
Log Message:
-----------
Skip KVM probe for OpenSolaris

Modified Paths:
--------------
    trunk/configure

Modified: trunk/configure
===================================================================
--- trunk/configure	2009-04-13 16:18:34 UTC (rev 7100)
+++ trunk/configure	2009-04-13 16:23:22 UTC (rev 7101)
@@ -278,6 +278,7 @@
     make="gmake"
     install="ginstall"
     needs_libsunmath="no"
+    kvm="no"
     solarisrev=`uname -r | cut -f2 -d.`
     # have to select again, because `uname -m` returns i86pc
     # even on an x86_64 box.

Re: [Qemu-devel] [7101] Skip KVM probe for OpenSolaris

[Anthony Liguori]

Blue Swirl wrote:
> Revision: 7101
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7101
> Author:   blueswir1
> Date:     2009-04-13 16:23:22 +0000 (Mon, 13 Apr 2009)
> Log Message:
> -----------
> Skip KVM probe for OpenSolaris
>   

The detection of "Solaris" depends on uname output.  This breaks if 
you're cross compiling.

Concretely, if you attempted to cross compile QEMU for Linux in a 
Solaris environment, this patch would break KVM support.

Was this a reason to disable this problem other than it being "unnecessary"?

Regards,

Anthony Liguori

Re: [Qemu-devel] [7101] Skip KVM probe for OpenSolaris

[Blue Swirl]

On 4/13/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Blue Swirl wrote:
>
> > Revision: 7101
> >
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7101
> > Author:   blueswir1
> > Date:     2009-04-13 16:23:22 +0000 (Mon, 13 Apr 2009)
> > Log Message:
> > -----------
> > Skip KVM probe for OpenSolaris
> >
> >
>
>  The detection of "Solaris" depends on uname output.  This breaks if you're
> cross compiling.

Maybe I should add the compile time check for OpenSolaris and OpenBSD.

>  Concretely, if you attempted to cross compile QEMU for Linux in a Solaris
> environment, this patch would break KVM support.
>
>  Was this a reason to disable this problem other than it being
> "unnecessary"?

Yes, but also native awk doesn't support -F switch with a regexp
instead of single character and I must confess that I don't know
enough awk to fix it other way.

Re: [Qemu-devel] [7101] Skip KVM probe for OpenSolaris

[Anthony Liguori]

Blue Swirl wrote:
>>  Concretely, if you attempted to cross compile QEMU for Linux in a Solaris
>> environment, this patch would break KVM support.
>>
>>  Was this a reason to disable this problem other than it being
>> "unnecessary"?
>>     
>
> Yes, but also native awk doesn't support -F switch with a regexp
> instead of single character and I must confess that I don't know
> enough awk to fix it other way.
>   

Christian: could you rework the awk expression to not require -F?

Regards,

Anthony LIguori