From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Luuq7-0004Yd-UH for qemu-devel@nongnu.org; Fri, 17 Apr 2009 16:39:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Luuq3-0004Xl-I8 for qemu-devel@nongnu.org; Fri, 17 Apr 2009 16:39:11 -0400 Received: from [199.232.76.173] (port=59559 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Luuq3-0004Xi-B4 for qemu-devel@nongnu.org; Fri, 17 Apr 2009 16:39:07 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:32844) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Luuq2-0004mR-UG for qemu-devel@nongnu.org; Fri, 17 Apr 2009 16:39:07 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e36.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3HKbagV032323 for ; Fri, 17 Apr 2009 14:37:36 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3HKd5lg227716 for ; Fri, 17 Apr 2009 14:39:05 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3HKd57j002801 for ; Fri, 17 Apr 2009 14:39:05 -0600 Message-ID: <49E8E8E7.2000407@us.ibm.com> Date: Fri, 17 Apr 2009 15:39:03 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount() References: <1239969879-5611-1-git-send-email-kwolf@redhat.com> <1239976920-4912-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1239976920-4912-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Christoph Hellwig Hi Christoph, Do you have a qemu-io script handy that can be used to stress something like this patch set? After the last qcow2 regression, I'm wary of additional cleanups that we can't validate with a strong stress test. Regards, Anthony Liguori kwolf@redhat.com wrote: > From: Kevin Wolf > > This code is currently only compiled when DEBUG_ALLOC is defined, so you > usually don't see compiler warnings on it. This patch series wants to enable > the code, so fix the format string warnings first. > > While we're at it, let's print error messages to stderr. > > Signed-off-by: Kevin Wolf > -- Regards, Anthony Liguori