From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Luuvb-0006KI-Jl
	for qemu-devel@nongnu.org; Fri, 17 Apr 2009 16:44:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LuuvW-0006E3-Pj
	for qemu-devel@nongnu.org; Fri, 17 Apr 2009 16:44:50 -0400
Received: from [199.232.76.173] (port=40294 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LuuvW-0006Dh-6x
	for qemu-devel@nongnu.org; Fri, 17 Apr 2009 16:44:46 -0400
Received: from e2.ny.us.ibm.com ([32.97.182.142]:35116)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LuuvV-0005bV-S6
	for qemu-devel@nongnu.org; Fri, 17 Apr 2009 16:44:46 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e2.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3HKfKig008572
	for <qemu-devel@nongnu.org>; Fri, 17 Apr 2009 16:41:20 -0400
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n3HKiixp177314
	for <qemu-devel@nongnu.org>; Fri, 17 Apr 2009 16:44:44 -0400
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n3HKiiuW030457
	for <qemu-devel@nongnu.org>; Fri, 17 Apr 2009 16:44:44 -0400
Message-ID: <49E8EA39.5010801@us.ibm.com>
Date: Fri, 17 Apr 2009 15:44:41 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1239789151-23552-1-git-send-email-kwolf@redhat.com>
In-Reply-To: <1239789151-23552-1-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] qcow2 corruption: Fix alloc_cluster_link_l2
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: dlaor@redhat.com, qemu-devel@nongnu.org, gleb@redhat.com

Kevin Wolf wrote:
> This patch fixes a qcow2 corruption bug introduced in SVN Rev 5861. L2 tables
> are big endian, so entries must be converted before being passed to functions.
>
> This bug is easy to trigger. The following script will create and destroy a
> qcow2 image (the header is gone after three loop iterations):
>
>     #!/bin/bash
>     qemu-img create -f qcow2 test.qcow 1M
>     for i in $(seq 1 10); do
>     qemu-system-x86_64 -hda test.qcow -monitor stdio > /dev/null 2>&1 <<EOF
>     savevm test-$i
>     quit
>     EOF
>     done
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Applied to stable and trunk.  Thanks!

-- 
Regards,

Anthony Liguori