From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LuvE1-0007dV-Nb for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:03:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LuvDw-0007cP-Sx for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:03:53 -0400 Received: from [199.232.76.173] (port=58419 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LuvDw-0007cG-MM for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:03:48 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.142]:39020) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LuvDv-0000u5-Td for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:03:48 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e2.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3HL0LuE030442 for ; Fri, 17 Apr 2009 17:00:21 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3HL3k5A196828 for ; Fri, 17 Apr 2009 17:03:46 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3HL3jDV029139 for ; Fri, 17 Apr 2009 17:03:46 -0400 Message-ID: <49E8EEAE.6000403@us.ibm.com> Date: Fri, 17 Apr 2009 16:03:42 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount() References: <1239969879-5611-1-git-send-email-kwolf@redhat.com> <1239976920-4912-1-git-send-email-kwolf@redhat.com> <49E8E8E7.2000407@us.ibm.com> <200904172300.34596@kevin-wolf.de> In-Reply-To: <200904172300.34596@kevin-wolf.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Kevin Wolf , Christoph Hellwig , qemu-devel@nongnu.org Kevin Wolf wrote: > Hi Anthony, > > Am Freitag, 17. April 2009 22:39 schrieb Anthony Liguori: > >> Do you have a qemu-io script handy that can be used to stress something >> like this patch set? After the last qcow2 regression, I'm wary of >> additional cleanups that we can't validate with a strong stress test. >> > > This patch series is harmless in that respect. You can tell alone from looking > at the patches that it can't cause regressions in normal operation, because > it only touches code which was previosuly not even built and is only called > by qemu-img (after patch 3) and when DEBUG_ALLOC is defined. > I'm basically at the point of not wanting to touch qcow2 without serious testing. That said, I can do enough on my own to satisfy me so I'll commit this series later today or tomorrow. > But you would better apply the corruption fix I sent on Wednesday. ;-) > Yes, I just checked that in. Very good catch! > And even though I think that this series can't break anything, we definitely > could use a strong test suite. I'm almost sure that there is at least one bug > left (the one Jamie Lokier saw from 5006 on, but nobody ever found it). > You don't think that was Nolan's fix? > Kevin > -- Regards, Anthony Liguori