From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LuvUz-0005jn-Ay
	for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:21:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LuvUs-0005cj-Lm
	for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:21:23 -0400
Received: from [199.232.76.173] (port=39750 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LuvUr-0005cP-Kw
	for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:21:18 -0400
Received: from e6.ny.us.ibm.com ([32.97.182.146]:60932)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LuvUr-0002nc-3j
	for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:21:17 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e6.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3HLN5Gb008323
	for <qemu-devel@nongnu.org>; Fri, 17 Apr 2009 17:23:05 -0400
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n3HLLGHs154046
	for <qemu-devel@nongnu.org>; Fri, 17 Apr 2009 17:21:16 -0400
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n3HLLGQq006676
	for <qemu-devel@nongnu.org>; Fri, 17 Apr 2009 17:21:16 -0400
Message-ID: <49E8F2C9.9050705@us.ibm.com>
Date: Fri, 17 Apr 2009 16:21:13 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH][STABLE] hpet: Fix emulation of HPET_TN_SETVAL
References: <49E79023.5090107@web.de>
In-Reply-To: <49E79023.5090107@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Beth Kon <eak@us.ibm.com>, Alexander Graf <agraf@suse.de>, Gleb Natapov <gleb@redhat.com>, Dmitry Eremin-Solenikov <dmitry.baryshkov@siemens.com>

Jan Kiszka wrote:
> While Intel's spec is not that clear here, latest changes to Linux' HPET
> code (commit c23e253e67c9d8a91a0ffa33c1f571a17f0a2403, "x86: hpet: stop
> HPET_COUNTER when programming periodic mode") strongly suggest that
> HPET_TN_SETVAL rather means: Set _both_ the comparator value and
> register.
>
> With this patch applied, I'm again able to boot 2.6.30-rc kernels as
> they no longer panic like this (which was due to the comparator
> register remaining 0):
>
> ENABLING IO-APIC IRQs
> ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1 pin2=-1
> ..MP-BIOS bug: 8254 timer not connected to IO-APIC
> ...trying to set up timer (IRQ0) through the 8259A ...
> ..... (found apic 0 pin 2) ...
> ....... failed.
> ...trying to set up timer as Virtual Wire IRQ...
> ..... failed.
> ...trying to set up timer as ExtINT IRQ...
> ..... failed :(.
> Kernel panic - not syncing: IO-APIC + timer doesn't work! [...]
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>   
Applied to trunk and stable.  Thanks.

-- 
Regards,

Anthony Liguori