From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LuwbK-0000vP-45 for qemu-devel@nongnu.org; Fri, 17 Apr 2009 18:32:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LuwbF-0000tY-ES for qemu-devel@nongnu.org; Fri, 17 Apr 2009 18:32:01 -0400 Received: from [199.232.76.173] (port=55120 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LuwbF-0000tT-B3 for qemu-devel@nongnu.org; Fri, 17 Apr 2009 18:31:57 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:41213) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LuwbE-0004d7-O6 for qemu-devel@nongnu.org; Fri, 17 Apr 2009 18:31:57 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e34.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3HMTVI4024729 for ; Fri, 17 Apr 2009 16:29:31 -0600 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3HMVqll228508 for ; Fri, 17 Apr 2009 16:31:52 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3HMVq1R013381 for ; Fri, 17 Apr 2009 16:31:52 -0600 Message-ID: <49E90356.1090305@us.ibm.com> Date: Fri, 17 Apr 2009 17:31:50 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount() References: <1239969879-5611-1-git-send-email-kwolf@redhat.com> <200904172319.55735@kevin-wolf.de> <49E8FDA1.2030505@us.ibm.com> <200904180029.06432@kevin-wolf.de> In-Reply-To: <200904180029.06432@kevin-wolf.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Kevin Wolf , Christoph Hellwig , qemu-devel@nongnu.org Kevin Wolf wrote: > Am Samstag, 18. April 2009 00:07 schrieben Sie: > >> Every patch I commit gets tested. I have various tests that I run >> depending on which subsystem the patch touches. Right now, for qcow2, I >> don't have nearly enough. I was hoping that Christoph had something >> laying around that I could use since it looks like qemu-io would be a >> great harness for qcow2 changes. >> > > It is, definitely. qemu-io is the other part which I needed. But qemu-io alone > won't make you happy. It can exercise a lot of code, but it can't tell you if > your image is broken in the end. Except for reading back written data, of > course, but breakage is often enough more subtle. > > >> But I can write a pretty easy script myself on top of qemu-io so it's no >> big deal. I'm not suggesting holding up development. >> > > Heh, so everyone is writing his own scripts. What would you think about > bringing the test cases you use into the repository? > Yeah, I've been wanting to do everything via kvm-autotest but so far, it's not quite up to what I want to use it for. I'll see about cleaning up some of my scripts and posting them. The problem is they rely on custom images. -- Regards, Anthony Liguori