From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LvDd4-00039r-RY
	for qemu-devel@nongnu.org; Sat, 18 Apr 2009 12:42:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LvDd0-00039F-B1
	for qemu-devel@nongnu.org; Sat, 18 Apr 2009 12:42:58 -0400
Received: from [199.232.76.173] (port=52391 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LvDd0-00039C-7K
	for qemu-devel@nongnu.org; Sat, 18 Apr 2009 12:42:54 -0400
Received: from yx-out-1718.google.com ([74.125.44.155]:56764)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LvDcz-0003lV-SQ
	for qemu-devel@nongnu.org; Sat, 18 Apr 2009 12:42:53 -0400
Received: by yx-out-1718.google.com with SMTP id 6so61013yxn.82
	for <qemu-devel@nongnu.org>; Sat, 18 Apr 2009 09:42:53 -0700 (PDT)
Message-ID: <49EA030A.8090104@codemonkey.ws>
Date: Sat, 18 Apr 2009 11:42:50 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and
	install a compat symlink
References: <20090418160104.GA18120@volta.aurel32.net>
In-Reply-To: <20090418160104.GA18120@volta.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Aurelien Jarno wrote:
> For historical reasons, qemu system on i386 is called qemu instead of
> qemu-system-i386. This seems to confuse users.
>
> This patch installs it as qemu-system-i386, and create a compatibility
> symlink qemu -> qemu-system-i386 as some tools may call it that way.
> We can change or remove this symlink after a few releases when all the
> tools have migrated to this new name.
>   

I agree.

Regards,

Anthony Liguori

> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  Makefile.target |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index dae339b..88c7a32 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -63,12 +63,8 @@ ifdef CONFIG_USER_ONLY
>  QEMU_PROG=qemu-$(TARGET_ARCH2)
>  else
>  # system emulator name
> -ifeq ($(TARGET_ARCH), i386)
> -QEMU_PROG=qemu$(EXESUF)
> -else
>  QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
>  endif
> -endif
>  
>  PROGS=$(QEMU_PROG)
>  
> @@ -743,6 +739,9 @@ install: all
>  ifneq ($(PROGS),)
>  	$(INSTALL) -m 755 $(STRIP_OPT) $(PROGS) "$(DESTDIR)$(bindir)"
>  endif
> +ifeq ($(TARGET_ARCH), i386)
> +	ln -sf qemu-system-i386$(EXESUF) "$(DESTDIR)$(bindir)/qemu$(EXESUF)"
> +endif
>  
>  # Include automatically generated dependency files
>  -include $(wildcard *.d */*.d)
>