[Qemu-devel] Re: [PATCH v2 03/11] net: Prevent multiple slirp instances

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

Blue Swirl wrote:
> On 4/19/09, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> The slirp stack is full of global variables which prevents instantiating
>>  it more than once. Catch this during net_slirp_init to prevent more harm
>>  later on.
> 
> Alternatively the slirp stack could be taught to support multiple instances:
> http://lists.gnu.org/archive/html/qemu-devel/2007-10/msg00470.html
> 

For sure - and nice to know that there is a reference! But as your patch
demonstrates, it's a larger effort which comes with some risks of
regression. Therefore I didn't attack this in the first step.

My next to-do item /wrt slirp is making those special IPs and DHCP
ranges fully configurable (ie. dhcpserver=..., gateway=...,
dhcpstart=... etc.). Depending on how many lines I'll have to touch
anyway, I may append multi-instance support to this as well.

In the meantime, and specifically for stable, my patch is required to
catch breakages users can trigger when they do not know about this slirp
limitation.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]