From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LvVZ4-000359-KV for qemu-devel@nongnu.org; Sun, 19 Apr 2009 07:52:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LvVYx-00031v-Jz for qemu-devel@nongnu.org; Sun, 19 Apr 2009 07:52:00 -0400 Received: from [199.232.76.173] (port=56324 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LvVYw-00031P-6e for qemu-devel@nongnu.org; Sun, 19 Apr 2009 07:51:54 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:41838) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LvVYv-0007t4-I3 for qemu-devel@nongnu.org; Sun, 19 Apr 2009 07:51:53 -0400 Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216]) by fmmailgate01.web.de (Postfix) with ESMTP id 52E7110040581 for ; Sun, 19 Apr 2009 13:51:52 +0200 (CEST) Received: from [88.65.39.244] (helo=[192.168.1.123]) by smtp08.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #277) id 1LvVYu-0002wo-00 for qemu-devel@nongnu.org; Sun, 19 Apr 2009 13:51:52 +0200 Message-ID: <49EB1052.6030506@web.de> Date: Sun, 19 Apr 2009 13:51:46 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20090419100424.24240.51439.stgit@mchn012c.ww002.siemens.net> <20090419100425.24240.56844.stgit@mchn012c.ww002.siemens.net> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig69573C31B3D155B77092322B" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH v2 03/11] net: Prevent multiple slirp instances Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig69573C31B3D155B77092322B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Blue Swirl wrote: > On 4/19/09, Jan Kiszka wrote: >> The slirp stack is full of global variables which prevents instantiati= ng >> it more than once. Catch this during net_slirp_init to prevent more h= arm >> later on. >=20 > Alternatively the slirp stack could be taught to support multiple insta= nces: > http://lists.gnu.org/archive/html/qemu-devel/2007-10/msg00470.html >=20 For sure - and nice to know that there is a reference! But as your patch demonstrates, it's a larger effort which comes with some risks of regression. Therefore I didn't attack this in the first step. My next to-do item /wrt slirp is making those special IPs and DHCP ranges fully configurable (ie. dhcpserver=3D..., gateway=3D..., dhcpstart=3D... etc.). Depending on how many lines I'll have to touch anyway, I may append multi-instance support to this as well. In the meantime, and specifically for stable, my patch is required to catch breakages users can trigger when they do not know about this slirp limitation. Jan --------------enig69573C31B3D155B77092322B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAknrEFcACgkQniDOoMHTA+kGXQCfa78eKeKoGnWvDxM308pJnwub +/8AnjIozy1XQgaoRgiNWz7wCykJwd9t =9xvf -----END PGP SIGNATURE----- --------------enig69573C31B3D155B77092322B--