From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LvZcc-0004zZ-Di for qemu-devel@nongnu.org; Sun, 19 Apr 2009 12:11:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LvZcY-0004zC-0w for qemu-devel@nongnu.org; Sun, 19 Apr 2009 12:11:57 -0400 Received: from [199.232.76.173] (port=34191 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LvZcX-0004z7-Mc for qemu-devel@nongnu.org; Sun, 19 Apr 2009 12:11:53 -0400 Received: from mx2.redhat.com ([66.187.237.31]:49493) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LvZcX-0004Eh-7G for qemu-devel@nongnu.org; Sun, 19 Apr 2009 12:11:53 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3JGBqjQ011753 for ; Sun, 19 Apr 2009 12:11:52 -0400 Message-ID: <49EB4D42.4050206@redhat.com> Date: Sun, 19 Apr 2009 19:11:46 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting patches References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Blue Swirl wrote: > Hi, > > I gathered a few common complaints about patch submission, hopefully > not too much affected by my consumption of small amounts of various > alcoholic substances. > > > + > +SP2.3: The description must be followed by one blank line and a > +"Signed-off-by:" line A signoff is more than a format; it is a legal declaration, see the Linux Documentation/SubmittingPatches. It should be clear to the submitter that this is so. IIRC, one of the requirements is to use your real name :) > > + > +SP3.2: If possible, please send the patch inlined (to make commenting > +easier) and also attached (to make it easier to apply) If the patch is attached (and not inlined) it should be marked as text/plain content type. > > + > +SP4.4: The patches targeted for development branch must be based on > +the current development repository > + > +SP4.5: The patches targeted for stable branch must be based on the > +current stable repository Suggest instead: patches should state which branch they are based on, and should be based on a recent version of the branch. In addition: When sending multiple patches, patches should be numbered (inside the brackets: [PATCH 09/17]) and should include a cover letter describing the patchset in general (as opposed to infividual patch descriptions). Patch management utilities (git send-email, quilt, and similar) can do this, so their use is recommended. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.