From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LvuPf-0005bi-Ql
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 10:24:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LvuPZ-0005Zv-E7
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 10:23:57 -0400
Received: from [199.232.76.173] (port=36314 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LvuPY-0005Zi-HY
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 10:23:52 -0400
Received: from rv-out-0708.google.com ([209.85.198.251]:35906)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LvuPY-0006Gy-6s
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 10:23:52 -0400
Received: by rv-out-0708.google.com with SMTP id c5so411873rvf.22
	for <qemu-devel@nongnu.org>; Mon, 20 Apr 2009 07:23:51 -0700 (PDT)
Message-ID: <49EC8572.9080606@codemonkey.ws>
Date: Mon, 20 Apr 2009 09:23:46 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH,
	RFC] Add file describing rules for submitting patches
References: <f43fc5580904190832g413e67bn494f696a3e3279f4@mail.gmail.com>	<49EB55D8.7020903@web.de>
	<20090419.114116.371475325.imp@bsdimp.com>
In-Reply-To: <20090419.114116.371475325.imp@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: jan.kiszka@web.de

M. Warner Losh wrote:
> In message: <49EB55D8.7020903@web.de>
>             Jan Kiszka <jan.kiszka@web.de> writes:
> : Blue Swirl wrote:
> : > Hi,
> : > 
> : > I gathered a few common complaints about patch submission, hopefully
> : > not too much affected by my consumption of small amounts of various
> : > alcoholic substances.
> : 
> : Don't drink and patch. Oh, wait, this was: "Don't drink and derive!" So
> : this is probably ok.
> : 
> : > 
> : > Comments, objections?
> : 
> : SP3.2: If you only attach, pleeeease don't use base64 encoding etc. And
> : there should be no maintainer exception...
>
> How can you attach a patch with MIME and not do that?
>   

If you tolerate MIME, you have to accept different encoding types 
(including base64).  Right now, just accepting text/plain and 
text/x-diff seems to work well enough.  The most common failure for my 
scripts wrt attachments is with mailers that do application/binary or 
some similarly opaque mime type.  What's particularly bad are mailers 
that send a plain text descriptions, HTML descriptions, and then the 
patch.  This last two categories are too difficult to handle correctly 
in scripts so that's where I want to bounce.  It's not a huge problem 
though.  It only happens in < %1 of patches.

Regards,

Anthony Liguori

> Warner
>
>
>