From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LvuWo-0000JL-SD for qemu-devel@nongnu.org; Mon, 20 Apr 2009 10:31:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LvuWi-0000Di-Su for qemu-devel@nongnu.org; Mon, 20 Apr 2009 10:31:22 -0400 Received: from [199.232.76.173] (port=54761 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LvuWi-0000DV-8e for qemu-devel@nongnu.org; Mon, 20 Apr 2009 10:31:16 -0400 Received: from mx2.redhat.com ([66.187.237.31]:58623) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LvuWh-0007Op-LM for qemu-devel@nongnu.org; Mon, 20 Apr 2009 10:31:16 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3KEVDOW021141 for ; Mon, 20 Apr 2009 10:31:13 -0400 Message-ID: <49EC872F.9010605@redhat.com> Date: Mon, 20 Apr 2009 17:31:11 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting patches References: <49EC82FC.9060108@codemonkey.ws> In-Reply-To: <49EC82FC.9060108@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: > Blue Swirl wrote: >> Hi, >> >> I gathered a few common complaints about patch submission, hopefully >> not too much affected by my consumption of small amounts of various >> alcoholic substances. >> >> Comments, objections? >> +SP2.5: Exception: For extremely short and trivial patches (one-line >> +fixes etc.), the description and "Signed-off-by:" lines may be >> +omitted, in which case the subject must be appended with the >> +submitter's name in parenthesis > > Signed-off-by can never be omitted--even for one line fixes. Oh, and you don't need the author's name if we switch to git. -- error compiling committee.c: too many arguments to function