From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lvvo2-00023e-VM for qemu-devel@nongnu.org; Mon, 20 Apr 2009 11:53:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lvvny-00021C-Gr for qemu-devel@nongnu.org; Mon, 20 Apr 2009 11:53:14 -0400 Received: from [199.232.76.173] (port=58198 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lvvny-000219-EY for qemu-devel@nongnu.org; Mon, 20 Apr 2009 11:53:10 -0400 Received: from mx2.redhat.com ([66.187.237.31]:56775) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lvvnx-0006Bj-Qp for qemu-devel@nongnu.org; Mon, 20 Apr 2009 11:53:10 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3KFr7H2012369 for ; Mon, 20 Apr 2009 11:53:07 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n3KFr6cH006619 for ; Mon, 20 Apr 2009 11:53:07 -0400 Received: from dhcp-5-204.str.redhat.com (dhcp-5-204.str.redhat.com [10.32.5.204]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n3KFr5vJ002697 for ; Mon, 20 Apr 2009 11:53:06 -0400 Message-ID: <49EC9A6C.90902@redhat.com> Date: Mon, 20 Apr 2009 17:53:16 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting patches References: <49EC8372.9080504@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Blue Swirl schrieb: > On 4/20/09, Anthony Liguori wrote: >> Blue Swirl wrote: >> >>> Hi, >>> >>> I gathered a few common complaints about patch submission, hopefully >>> not too much affected by my consumption of small amounts of various >>> alcoholic substances. >>> >>> Comments, objections? >>> >>> >> >>> +SP4.1: It must be possible to apply the patch with quilt (equivalent >>> +to patch -p1) and "git am" without any editing or extra flags >>> >> svn diff generates -p0 patches so both -p1 and -p0 should be accepted. > > Quilt does not accept -p0 patches without extra work. Remember, the > idea is to reduce our burden, make it easier to test and apply > patches. I think you'll survive the extra work of adding a -p0 to your series file from time to time. Currently SVN is the official solution of qemu and it's not obvious how you would create -p1 patches with svn diff. And nowadays most patches are generated with git anyway. Kevin