From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lvxj6-0007MV-T8
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 13:56:16 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lvxj2-0007L3-HO
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 13:56:16 -0400
Received: from [199.232.76.173] (port=34989 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lvxj2-0007Kz-6C
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 13:56:12 -0400
Received: from rv-out-0708.google.com ([209.85.198.251]:51912)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Lvxj1-0005is-Pn
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 13:56:11 -0400
Received: by rv-out-0708.google.com with SMTP id f25so812685rvb.2
	for <qemu-devel@nongnu.org>; Mon, 20 Apr 2009 10:56:10 -0700 (PDT)
Message-ID: <49ECB734.1020207@codemonkey.ws>
Date: Mon, 20 Apr 2009 12:56:04 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting
	patches
References: <f43fc5580904190832g413e67bn494f696a3e3279f4@mail.gmail.com>	<49EC8372.9080504@codemonkey.ws>
	<f43fc5580904200829n5761bfc8i78852aa7fe56e8ad@mail.gmail.com>
In-Reply-To: <f43fc5580904200829n5761bfc8i78852aa7fe56e8ad@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Blue Swirl wrote:
> On 4/20/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
>   
>> Blue Swirl wrote:
>>
>>     
>>> Hi,
>>>
>>> I gathered a few common complaints about patch submission, hopefully
>>> not too much affected by my consumption of small amounts of various
>>> alcoholic substances.
>>>
>>> Comments, objections?
>>>
>>>
>>>       
>>     
>>> +SP4.1: It must be possible to apply the patch with quilt (equivalent
>>> +to patch -p1) and "git am" without any editing or extra flags
>>>
>>>       
>>  svn diff generates -p0 patches so both -p1 and -p0 should be accepted.
>>     
>
> Quilt does not accept -p0 patches without extra work. Remember, the
> idea is to reduce our burden, make it easier to test and apply
> patches.
>   

guilt does ;-)

FWIW, I'm working on getting the email commit script in place for the 
Savannah git repo.  That's the last bit needed to switch from svn -> git.

After that, a git-send-email requirement (or equiv) would make a lot of 
sense as it significantly reduces the maintainers work via git-am.

Regards,

Anthony Liguori

> Diff can generate other types of diffs besides the unified type but we
> don't want any other.
>
>
>