From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 1/2] Rework -boot option
Date: Mon, 20 Apr 2009 20:34:06 +0200 [thread overview]
Message-ID: <49ECC01E.80605@web.de> (raw)
In-Reply-To: <49ECB940.5060100@codemonkey.ws>
[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]
Anthony Liguori wrote:
> Jan Kiszka wrote:
>> This patch changes the boot command line option to the canonical format
>>
>> -boot [order=drives][,interactive=on|off]
>>
>> where 'drives' is using the same format as the old -boot. The new format
>> is required in order to add the 'interactive' option and use the
>> existing infrastructure to parse it.
>>
>> The state of 'interactive' is transfered to the firmware via the new
>> configuration value FW_CFG_BOOT_INTERACTIVE.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>
>
> This breaks compatibility with existing management tools. Can't we do:
>
> -boot [order=]drives[,interactive=on|off]
>
> Certainly, -drive introduces a precedence for this type of format.
Everything is possible, but comes with a price:
- more complex code
- more ugly and inconsistent user interface
Is there no precedence for breaking the command line interface in order
to clean things up?
An alternative could be to keep -boot as is, at least for the next few
major releases, and introduce a new option with the proposed format. Not
much simpler, but a bit. And comes with the chance to drop the legacy at
some point. Any naming suggestions welcome!
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2009-04-20 18:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 17:05 [Qemu-devel] [PATCH 1/2] Rework -boot option Jan Kiszka
2009-04-20 18:04 ` Anthony Liguori
2009-04-20 18:34 ` Jan Kiszka [this message]
2009-04-20 18:41 ` [Qemu-devel] " Avi Kivity
2009-04-20 20:01 ` [Qemu-devel] [PATCH 1/2 -v] " Jan Kiszka
2009-04-20 19:13 ` [Qemu-devel] Re: [PATCH 1/2] " Anthony Liguori
2009-04-20 18:38 ` [Qemu-devel] " Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ECC01E.80605@web.de \
--to=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).