From: Kevin Wolf <kwolf@redhat.com>
To: aliguori@us.ibm.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount()
Date: Tue, 21 Apr 2009 18:19:01 +0200 [thread overview]
Message-ID: <49EDF1F5.8050000@redhat.com> (raw)
In-Reply-To: <49E8EEAE.6000403@us.ibm.com>
Anthony Liguori schrieb:
> Kevin Wolf wrote:
>> And even though I think that this series can't break anything, we
>> definitely could use a strong test suite. I'm almost sure that there
>> is at least one bug left (the one Jamie Lokier saw from 5006 on, but
>> nobody ever found it).
>>
>
> You don't think that was Nolan's fix?
I've finally looked at the code longer than ten seconds and noticed that
a) I misunderstood the patch comment and b) the code looks different
than I seemed to remember. So I can live now with the assumption that it
was what Nolan's fix addresses, doesn't seem too unlikely.
Kevin
next prev parent reply other threads:[~2009-04-21 16:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 12:04 [Qemu-devel] [PATCH 0/5] Add qemu-img check subcommand Kevin Wolf
2009-04-17 12:40 ` [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount() Kevin Wolf
2009-04-17 14:01 ` kwolf
2009-04-17 20:39 ` Anthony Liguori
2009-04-17 21:00 ` Kevin Wolf
2009-04-17 21:03 ` Anthony Liguori
2009-04-17 21:19 ` Kevin Wolf
2009-04-17 22:07 ` Anthony Liguori
2009-04-17 22:29 ` Kevin Wolf
2009-04-17 22:31 ` Anthony Liguori
2009-04-18 0:11 ` Ryan Harper
2009-04-20 13:48 ` Christoph Hellwig
2009-04-21 16:19 ` Kevin Wolf [this message]
2009-04-20 13:46 ` Christoph Hellwig
2009-04-21 23:12 ` Anthony Liguori
2009-04-17 14:01 ` [Qemu-devel] [PATCH 2/5] Introduce bdrv_check kwolf
2009-04-17 14:01 ` [Qemu-devel] [PATCH 3/5] Introduce qemu-img check subcommand kwolf
2009-04-17 14:01 ` [Qemu-devel] [PATCH 4/5] qcow2: Refcount checking code cleanup kwolf
2009-04-21 8:32 ` [Qemu-devel] [PATCH v2 " Kevin Wolf
2009-04-17 14:02 ` [Qemu-devel] [PATCH 5/5] qcow2: Add plausibility check for L1/L2 entries kwolf
2009-04-20 10:30 ` [Qemu-devel] [PATCH 0/5] Add qemu-img check subcommand Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EDF1F5.8050000@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).