From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LwIhc-00087K-Ox for qemu-devel@nongnu.org; Tue, 21 Apr 2009 12:20:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LwIhX-00084d-Ky for qemu-devel@nongnu.org; Tue, 21 Apr 2009 12:20:07 -0400 Received: from [199.232.76.173] (port=53590 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LwIhX-00084P-GY for qemu-devel@nongnu.org; Tue, 21 Apr 2009 12:20:03 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42209) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LwIhW-0005g9-VT for qemu-devel@nongnu.org; Tue, 21 Apr 2009 12:20:03 -0400 Message-ID: <49EDF1F5.8050000@redhat.com> Date: Tue, 21 Apr 2009 18:19:01 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount() References: <1239969879-5611-1-git-send-email-kwolf@redhat.com> <1239976920-4912-1-git-send-email-kwolf@redhat.com> <49E8E8E7.2000407@us.ibm.com> <200904172300.34596@kevin-wolf.de> <49E8EEAE.6000403@us.ibm.com> In-Reply-To: <49E8EEAE.6000403@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@us.ibm.com Cc: qemu-devel@nongnu.org Anthony Liguori schrieb: > Kevin Wolf wrote: >> And even though I think that this series can't break anything, we >> definitely could use a strong test suite. I'm almost sure that there >> is at least one bug left (the one Jamie Lokier saw from 5006 on, but >> nobody ever found it). >> > > You don't think that was Nolan's fix? I've finally looked at the code longer than ten seconds and noticed that a) I misunderstood the patch comment and b) the code looks different than I seemed to remember. So I can live now with the assumption that it was what Nolan's fix addresses, doesn't seem too unlikely. Kevin