From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LwKrP-0003Ex-Vi
	for qemu-devel@nongnu.org; Tue, 21 Apr 2009 14:38:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LwKrK-0003EY-UL
	for qemu-devel@nongnu.org; Tue, 21 Apr 2009 14:38:23 -0400
Received: from [199.232.76.173] (port=58170 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LwKrK-0003EV-Pw
	for qemu-devel@nongnu.org; Tue, 21 Apr 2009 14:38:18 -0400
Received: from mx2.redhat.com ([66.187.237.31]:46101)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1LwKrK-0000Tz-1e
	for qemu-devel@nongnu.org; Tue, 21 Apr 2009 14:38:18 -0400
Message-ID: <49EE1292.20608@redhat.com>
Date: Tue, 21 Apr 2009 21:38:10 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] resetting a stale VNC connection
References: <49EDC3B4.7030508@cisco.com>
	<49EDCC6F.1020703@redhat.com>	<49EDE1EF.4070203@cisco.com>
	<49EDF082.4050900@redhat.com> <49EDF220.2040200@redhat.com>
	<49EDF434.3000202@cisco.com> <49EDF574.9090506@redhat.com>
	<49EE1166.4040409@gmail.com>
In-Reply-To: <49EE1166.4040409@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Ahern <dsahern@gmail.com>
Cc: Yaniv Kaul <ykaul@redhat.com>, qemu-devel@nongnu.org

David Ahern wrote:
> This patch enables TCP keepalives on VNC connections. After 60-seconds
> of idle time, probes are sent every 2 seconds with the connection
> resetting after 4 failed probes. This might be a rather aggressive
> setting -- 8 seconds until connection is reset.
>
>   

I think you are right, it's too aggressive.  Maybe reduce it so it takes 
a minute until we give up.

> Also, I believe this is a linux-specific way of doing this; not sure
> what the posix/windows method is. Open to suggestions.
>   

At the very least, you need to wrap this in a #if defined(...) && 
defined (...) ... so it doesn't break compilation on hosts that don't 
support those socket options.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.