[Qemu-devel] [PATCH] add hw/Makefile ...

[Qemu-devel] [PATCH] add hw/Makefile ...

[Gerd Hoffmann]

[-- Attachment #1: Type: text/plain, Size: 106 bytes --]

   Hi,

... so you can type "make" in the hw/ subdir and it happens something 
useful ;)

cheers,
   Gerd

[-- Attachment #2: 0004-add-hw-Makefile.patch --]
[-- Type: text/plain, Size: 563 bytes --]

>From 7754e2fe0d2c955962e8a186e7f824b4b0139453 Mon Sep 17 00:00:00 2001
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 22 Apr 2009 12:39:24 +0200
Subject: [PATCH 04/10] add hw/Makefile

So typing "make" in hw/ does something useful.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
 create mode 100644 hw/Makefile

diff --git a/hw/Makefile b/hw/Makefile
new file mode 100644
index 0000000..625525c
--- /dev/null
+++ b/hw/Makefile
@@ -0,0 +1,2 @@
+all:
+	make -C .. $@
-- 
1.6.2.2

Re: [Qemu-devel] [PATCH] add hw/Makefile ...

[Christoph Egger]

On Wednesday 22 April 2009 13:10:48 Gerd Hoffmann wrote:
>    Hi,
>
> ... so you can type "make" in the hw/ subdir and it happens something
> useful ;)
>
> cheers,
>    Gerd

This is wrong. Use $(MAKE) or you break platforms where you have to use
"gmake", otherwise.

Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: [Qemu-devel] [PATCH] add hw/Makefile ...

[Gerd Hoffmann]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

On 04/22/09 14:17, Christoph Egger wrote:

> This is wrong. Use $(MAKE) or you break platforms where you have to use
> "gmake", otherwise.

Updated patch attached.

cheers,
   Gerd

[-- Attachment #2: 0003-add-hw-Makefile.patch --]
[-- Type: text/plain, Size: 564 bytes --]

>From f18c599455383522b3901d0585befc2afa8cfe93 Mon Sep 17 00:00:00 2001
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 22 Apr 2009 12:39:24 +0200
Subject: [PATCH 3/5] add hw/Makefile

So typing "make" in hw/ does something useful.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
 create mode 100644 hw/Makefile

diff --git a/hw/Makefile b/hw/Makefile
new file mode 100644
index 0000000..70ea257
--- /dev/null
+++ b/hw/Makefile
@@ -0,0 +1,2 @@
+all:
+	$(MAKE) -C .. $@
-- 
1.6.2.2

Re: [Qemu-devel] [PATCH] add hw/Makefile ...

[Christoph Egger]

On Wednesday 22 April 2009 14:50:09 Gerd Hoffmann wrote:
> On 04/22/09 14:17, Christoph Egger wrote:
> > This is wrong. Use $(MAKE) or you break platforms where you have to use
> > "gmake", otherwise.
>
> Updated patch attached.
>
> cheers,
>    Gerd

That's fine.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: [Qemu-devel] [PATCH] add hw/Makefile ...

[Paul Brook]

On Wednesday 22 April 2009, Gerd Hoffmann wrote:
>    Hi,
>
> ... so you can type "make" in the hw/ subdir and it happens something
> useful ;)

I'm not convinced it should do anything useful.

Paul

Re: [Qemu-devel] [PATCH] add hw/Makefile ...

[Anthony Liguori]

Paul Brook wrote:
> On Wednesday 22 April 2009, Gerd Hoffmann wrote:
>   
>>    Hi,
>>
>> ... so you can type "make" in the hw/ subdir and it happens something
>> useful ;)
>>     
>
> I'm not convinced it should do anything useful.
>   

Neither am I.  I'm pretty sure it would confuse me to do a top level 
build from a sub directory.

Regards,

Anthony Liguori
> Paul
>
>
>