From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LwekE-0000IS-VO for qemu-devel@nongnu.org; Wed, 22 Apr 2009 11:52:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LwekA-0000Dw-A6 for qemu-devel@nongnu.org; Wed, 22 Apr 2009 11:52:18 -0400 Received: from [199.232.76.173] (port=35392 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LwekA-0000Dp-4l for qemu-devel@nongnu.org; Wed, 22 Apr 2009 11:52:14 -0400 Received: from rv-out-0708.google.com ([209.85.198.249]:42552) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lwek9-0005bB-ON for qemu-devel@nongnu.org; Wed, 22 Apr 2009 11:52:13 -0400 Received: by rv-out-0708.google.com with SMTP id c5so24070rvf.22 for ; Wed, 22 Apr 2009 08:52:12 -0700 (PDT) Message-ID: <49EF3D28.50003@codemonkey.ws> Date: Wed, 22 Apr 2009 10:52:08 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 00/10] xen: pv domain support. References: <1240316408-15949-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1240316408-15949-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org Gerd Hoffmann wrote: > Hi, > > Next round, addressing review comments: > > * Fixup more "if (-1 == foo()) bar()" compare style. > * Fixup logging: kill fprintf(stderr, ...), use logging API. > * Kill some unneeded malloc failure checks. > > The patches are also rebased to latest git and got a few adaptions to > recent cha > Applied full series. Thanks. I think it can still use some love (some files missing copyrights/license, for instance), but it's all extremely well contained so there's little point in keeping it out of tree. Regards, Anthony Liguori > cheers, > Gerd > > > >