From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LwixX-0005C8-1l for qemu-devel@nongnu.org; Wed, 22 Apr 2009 16:22:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LwixS-00059j-9b for qemu-devel@nongnu.org; Wed, 22 Apr 2009 16:22:18 -0400 Received: from [199.232.76.173] (port=52996 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LwixS-00059b-1f for qemu-devel@nongnu.org; Wed, 22 Apr 2009 16:22:14 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:34240) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LwixR-00007x-Oq for qemu-devel@nongnu.org; Wed, 22 Apr 2009 16:22:13 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e9.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3MKBhZs018852 for ; Wed, 22 Apr 2009 16:11:43 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3MKMCDU155988 for ; Wed, 22 Apr 2009 16:22:12 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3MKMCnK018215 for ; Wed, 22 Apr 2009 16:22:12 -0400 Received: from squirrel.codemonkey.ws (sig-9-76-204-158.mts.ibm.com [9.76.204.158]) by d01av01.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n3MKMCgs018191 for ; Wed, 22 Apr 2009 16:22:12 -0400 Message-ID: <49EF7C73.3070902@us.ibm.com> Date: Wed, 22 Apr 2009 15:22:11 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] implement qemu_blockalign References: <49E35345.1090004@eu.citrix.com> In-Reply-To: <49E35345.1090004@eu.citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stefano Stabellini wrote: > Hi all, > this patch adds a buffer_alignment field to BlockDriverState and > implements a qemu_blockalign function that uses that field to allocate a > memory aligned buffer to be used by the block driver. > buffer_alignment is initialized to 512 but each block driver can set > a different value (at the moment none of them do). > This patch modifies ide.c, block-qcow.c, block-qcow2.c and block.c to > use qemu_blockalign instead of qemu_memalign. > There is only one place left that still uses qemu_memalign to allocate > buffers used by block drivers that is posix-aio-compat:handle_aiocb_rw > because it is not possible to get the BlockDriverState from that > function. However I think it is not important because posix-aio-compat > already deals with driver specific code so it is supposed to know its > own needs. > > Signed-off-by: Stefano Stabellini > Applied. Thanks. -- Regards, Anthony Liguori