From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lx59S-0001KM-A8 for qemu-devel@nongnu.org; Thu, 23 Apr 2009 16:04:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lx59N-0001Ix-R3 for qemu-devel@nongnu.org; Thu, 23 Apr 2009 16:04:06 -0400 Received: from [199.232.76.173] (port=51601 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lx59N-0001Iu-Nk for qemu-devel@nongnu.org; Thu, 23 Apr 2009 16:04:01 -0400 Received: from mx20.gnu.org ([199.232.41.8]:43538) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lx59N-000832-0J for qemu-devel@nongnu.org; Thu, 23 Apr 2009 16:04:01 -0400 Received: from rv-out-0708.google.com ([209.85.198.243]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lx59M-0002GR-2v for qemu-devel@nongnu.org; Thu, 23 Apr 2009 16:04:00 -0400 Received: by rv-out-0708.google.com with SMTP id c5so552448rvf.22 for ; Thu, 23 Apr 2009 13:03:58 -0700 (PDT) Message-ID: <49F0C9AA.1070703@codemonkey.ws> Date: Thu, 23 Apr 2009 15:03:54 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [7234] Use a more natural order References: <20090423185308.GH3795@csclub.uwaterloo.ca> <20090423191040.GI3795@csclub.uwaterloo.ca> <5d6222a80904231215p62c6594asc50230b252e892aa@mail.gmail.com> <49F0C826.4060503@codemonkey.ws> <20090423195902.GN3795@csclub.uwaterloo.ca> In-Reply-To: <20090423195902.GN3795@csclub.uwaterloo.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lennart Sorensen Cc: Blue Swirl , Glauber Costa , qemu-devel@nongnu.org Lennart Sorensen wrote: > On Thu, Apr 23, 2009 at 02:57:26PM -0500, Anthony Liguori wrote: > >> In all fairness, I usually only do that when it's something I think >> people would comment on. I probably would do a fix up like this by just >> committing. >> >> People miss things, it happens. No process is going to prevent it >> happening 100% of the time. >> > > If you can't bother to compile test it, you shouldn't be commiting. > Your time isn't worth that much more than everyone else that gets > inconvinienced by the sloppy commit. > > That's a procedure that can certainly help. > I was obviously referring to posting to the mailing list. I have a set of compilation and unit tests that get run before every commit. There are a lot of possible configuration options for QEMU. Sometimes the build breaks for some combination of configuration options and this is a difficult thing to address in a robust way. With a patch series, my scripts run through what I consider the most common set of configurations for each patch. Right now, it usually takes a good 30 minutes to go through a large series just to compile test with my default configurations. Regards, Anthony Liguori