From: Avi Kivity <avi@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
dlaor@redhat.com, qemu-devel@nongnu.org, gleb@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qcow2 corruption: Fix alloc_cluster_link_l2
Date: Sun, 26 Apr 2009 17:14:03 +0300 [thread overview]
Message-ID: <49F46C2B.9060705@redhat.com> (raw)
In-Reply-To: <20090426132444.GA22238@lst.de>
Christoph Hellwig wrote:
> Maybe it's time to make use of sparse's endianess annotations in qcow2
> to prevent further problems like this one
I'd much prefer strong type checking at compile time:
typedef struct le32 {
uint32_t blah;
} le32;
static inline le32 cpu_to_le32(uint32_t blah) { ... }
static inline uint32_t le32_to_cpu(le32 blah) { ... }
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-04-26 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 9:52 [Qemu-devel] [PATCH] qcow2 corruption: Fix alloc_cluster_link_l2 Kevin Wolf
2009-04-15 10:05 ` [Qemu-devel] " Gleb Natapov
2009-04-15 15:28 ` Consul
2009-04-16 6:30 ` Marc Bevand
2009-04-17 20:44 ` Anthony Liguori
2009-04-26 13:24 ` [Qemu-devel] " Christoph Hellwig
2009-04-26 14:14 ` Avi Kivity [this message]
2009-04-26 14:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F46C2B.9060705@redhat.com \
--to=avi@redhat.com \
--cc=dlaor@redhat.com \
--cc=gleb@redhat.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).