From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ly6hZ-0002lH-6A for qemu-devel@nongnu.org; Sun, 26 Apr 2009 11:55:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ly6hT-0002kO-PF for qemu-devel@nongnu.org; Sun, 26 Apr 2009 11:55:31 -0400 Received: from [199.232.76.173] (port=58820 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ly6hT-0002kE-Fa for qemu-devel@nongnu.org; Sun, 26 Apr 2009 11:55:27 -0400 Received: from mx2.redhat.com ([66.187.237.31]:38912) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ly6hS-00021p-Uw for qemu-devel@nongnu.org; Sun, 26 Apr 2009 11:55:27 -0400 Message-ID: <49F483E8.4050005@redhat.com> Date: Sun, 26 Apr 2009 18:55:20 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Move block format drivers to new directory 'bdrv' References: <1240759177-27527-1-git-send-email-avi@redhat.com> <20090426152943.GA27812@lst.de> In-Reply-To: <20090426152943.GA27812@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org Christoph Hellwig wrote: > On Sun, Apr 26, 2009 at 06:19:37PM +0300, Avi Kivity wrote: > >> Instead of crowding the top-level directory, give block format drivers their >> very own subdirectory. >> > > Please also move block.c. Also block/*.c would match the existing > convention, not that I care too much. > That was deliberate - I wanted to keep the block core in the top level directory, and move the block format drivers away. I'll change it if there's consensus that block/*.c (including block.c) is preferable. -- error compiling committee.c: too many arguments to function