From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ly76g-0006Ej-Cp for qemu-devel@nongnu.org; Sun, 26 Apr 2009 12:21:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ly76b-0006ET-I0 for qemu-devel@nongnu.org; Sun, 26 Apr 2009 12:21:29 -0400 Received: from [199.232.76.173] (port=50337 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ly76b-0006EQ-Ba for qemu-devel@nongnu.org; Sun, 26 Apr 2009 12:21:25 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42798) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ly76a-0006CE-UX for qemu-devel@nongnu.org; Sun, 26 Apr 2009 12:21:25 -0400 Message-ID: <49F48A01.4090308@redhat.com> Date: Sun, 26 Apr 2009 19:21:21 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2] kvm: Avoid COW if KVM MMU is asynchronous References: <49F451B9.8040205@web.de> <49F45CDB.205@redhat.com> <49F485DC.2080702@web.de> In-Reply-To: <49F485DC.2080702@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel , Gleb Natapov Jan Kiszka wrote: > If the KVM MMU is asynchronous (kernel does not support MMU_NOTIFIER), > we have to avoid COW for the guest memory. Otherwise we risk serious > breakage when guest pages change there physical locations due to COW > after fork. Seen when forking smbd during runtime via -smb. > > > last_ram_offset += size; > > + if (kvm_enabled()) > + kvm_setup_guest_memory(new_block->host, size); > + > return new_block->offset; > } > I feel a little bad about picking such small nits, but the if statement requires braces. -- error compiling committee.c: too many arguments to function