From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ly8Or-0006cr-Hb for qemu-devel@nongnu.org; Sun, 26 Apr 2009 13:44:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ly8Om-0006ap-Qr for qemu-devel@nongnu.org; Sun, 26 Apr 2009 13:44:21 -0400 Received: from [199.232.76.173] (port=58755 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ly8Om-0006ag-JE for qemu-devel@nongnu.org; Sun, 26 Apr 2009 13:44:16 -0400 Received: from mail-gx0-f176.google.com ([209.85.217.176]:43541) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ly8Ol-00012P-SS for qemu-devel@nongnu.org; Sun, 26 Apr 2009 13:44:16 -0400 Received: by gxk24 with SMTP id 24so3855346gxk.10 for ; Sun, 26 Apr 2009 10:44:15 -0700 (PDT) Message-ID: <49F49D6C.7080100@codemonkey.ws> Date: Sun, 26 Apr 2009 12:44:12 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Move block format drivers to new directory 'bdrv' References: <1240759177-27527-1-git-send-email-avi@redhat.com> <20090426152943.GA27812@lst.de> <49F483E8.4050005@redhat.com> <49F489B7.5000705@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, Avi Kivity , Christoph Hellwig Blue Swirl wrote: > On 4/26/09, Avi Kivity wrote: > >> Blue Swirl wrote: >> >> >>> Taking one step further, why not introduce directories similar to >>> >> VirtualBox: >> >>> http://www.virtualbox.org/browser/trunk/src/VBox >>> >>> >>> >>> >> No objection, but let's go one step at a time. >> > > Yes, but it's good to see the big picture. > > So the new 'host' directory would be like: > > . > |-- audio > |-- block > |-- bluetooth > |-- crypto > |-- net > | `-- slirp > |-- parport > |-- scsi > |-- serial > |-- usb > `-- video > There's an awful lot of code refactoring needed before such a layout would make sense. In general, I think until there are at least 3 files in the form something-foo.c, it doesn't make sense to convert to something/foo.c Regards, Anthony Liguori > audio and slirp are current directories. SDL and VNC go to video, aes > and d3des to crypto. > > >