From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LyPmm-0005QX-IB for qemu-devel@nongnu.org; Mon, 27 Apr 2009 08:18:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LyPmh-0005Me-F8 for qemu-devel@nongnu.org; Mon, 27 Apr 2009 08:18:12 -0400 Received: from [199.232.76.173] (port=39555 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LyPmh-0005MZ-3p for qemu-devel@nongnu.org; Mon, 27 Apr 2009 08:18:07 -0400 Received: from mx2.redhat.com ([66.187.237.31]:41682) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LyPmg-0000m8-Hc for qemu-devel@nongnu.org; Mon, 27 Apr 2009 08:18:06 -0400 Message-ID: <49F5A240.30204@redhat.com> Date: Mon, 27 Apr 2009 14:17:04 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Move block format drivers to new directory 'bdrv' References: <1240759177-27527-1-git-send-email-avi@redhat.com> <49F5A03C.7030606@redhat.com> <49F5A0BC.90508@redhat.com> In-Reply-To: <49F5A0BC.90508@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org Avi Kivity schrieb: > Kevin Wolf wrote: >> Avi Kivity schrieb: >>> Instead of crowding the top-level directory, give block format >>> drivers their >>> very own subdirectory. >>> >>> Signed-off-by: Avi Kivity >> >> I like this idea. In fact, I was going to suggest something like this >> myself. And a good next step would be to split up (too) large source >> files, e.g. into qcow2-snapshot.c, qcow2-refcount.c and so on. > > qcow2/snapshot.c qcow2/refcount.c ... I'm not sure about that one. A less crowded top level directory is a good thing, but building a directory labyrinth is not, IMHO. Kevin