* [Qemu-devel] [PATCH] Fix qemu_event_init
@ 2009-04-28 22:59 Jan Kiszka
2009-04-29 18:43 ` Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2009-04-28 22:59 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Marcelo Tosatti, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
Falling through to "fail" made qemu_event_init() close the pipe fds
immediately again, breaking timer event notification.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
vl.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index a210b6c..ac4b32f 100644
--- a/vl.c
+++ b/vl.c
@@ -3713,6 +3713,8 @@ static int qemu_event_init(void)
(void *)(unsigned long)fds[0]);
io_thread_fd = fds[1];
+ return 0;
+
fail:
close(fds[0]);
close(fds[1]);
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix qemu_event_init
2009-04-28 22:59 [Qemu-devel] [PATCH] Fix qemu_event_init Jan Kiszka
@ 2009-04-29 18:43 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2009-04-29 18:43 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Marcelo Tosatti, qemu-devel
On 4/29/09, Jan Kiszka <jan.kiszka@web.de> wrote:
> Falling through to "fail" made qemu_event_init() close the pipe fds
> immediately again, breaking timer event notification.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
This fixed also Sparc boot without a CD or disk. Thanks, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-29 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-28 22:59 [Qemu-devel] [PATCH] Fix qemu_event_init Jan Kiszka
2009-04-29 18:43 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).