From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LywGb-0005Ij-0E for qemu-devel@nongnu.org; Tue, 28 Apr 2009 18:59:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LywGV-0005IQ-HX for qemu-devel@nongnu.org; Tue, 28 Apr 2009 18:59:07 -0400 Received: from [199.232.76.173] (port=58676 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LywGV-0005IN-CV for qemu-devel@nongnu.org; Tue, 28 Apr 2009 18:59:03 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:49969) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LywGU-00067l-RC for qemu-devel@nongnu.org; Tue, 28 Apr 2009 18:59:03 -0400 Message-ID: <49F78A35.2060603@web.de> Date: Wed, 29 Apr 2009 00:59:01 +0200 From: Jan Kiszka MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigC4F0E58FBC16D882794A2680" Sender: jan.kiszka@web.de Subject: [Qemu-devel] [PATCH] Fix qemu_event_init List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Marcelo Tosatti , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC4F0E58FBC16D882794A2680 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Falling through to "fail" made qemu_event_init() close the pipe fds immediately again, breaking timer event notification. Signed-off-by: Jan Kiszka --- vl.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index a210b6c..ac4b32f 100644 --- a/vl.c +++ b/vl.c @@ -3713,6 +3713,8 @@ static int qemu_event_init(void) (void *)(unsigned long)fds[0]); io_thread_fd =3D fds[1]; + return 0; + fail: close(fds[0]); close(fds[1]); --------------enigC4F0E58FBC16D882794A2680 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkn3ijUACgkQniDOoMHTA+nTTACfRPW0jI7kuO72sicRDBx1avz3 9WkAnRrmw6YgcrkK6rdxhCgFFmfKZaNn =UkTT -----END PGP SIGNATURE----- --------------enigC4F0E58FBC16D882794A2680--