From: Anthony Liguori <aliguori@us.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Paul Brook <paul@codesourcery.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup()
Date: Thu, 30 Apr 2009 11:41:05 -0500 [thread overview]
Message-ID: <49F9D4A1.7070005@us.ibm.com> (raw)
In-Reply-To: <49F9D3D8.3000704@us.ibm.com>
Anthony Liguori wrote:
> Avi Kivity wrote:
>> True, but is it actually useful?
>>
>> Short-circuiting two guest devices probably isn't. Adding host
>> devices (like recording packets) might be.
>
> But you can do this by just inserting yourself between the
> frontend/backend. You can do this dynamically as long as you don't
> require feature negotiation. Dynamic negotiation is prohibitively
> difficult and one of the primary reasons we haven't been able to merge
> vnet support for tap yet.
Paul: in KVM, tap devices support optional GSO/checksum offload
support. This is enabled for the tap device depending on whether you're
using virtio-net and your host kernel supports it.
In KVM, having > 1 guest device on a vlan is broken when a tap device in
on a vlan. This is by design because the dynamic feature negotiation
isn't always possible. The other option would be to disallow additional
VLAN that can't support the same features or do full GSO emulation
within QEMU.
Neither of these are very good options. No one has complained yet to
the best of my knowledge that you can't have more than one guest device
on a vlan in KVM. This is simply because no one ever does it :-)
--
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-04-30 16:41 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 16:29 [Qemu-devel] [PATCH 0/9] Misc networking fixes Mark McLoughlin
2009-04-15 16:29 ` [Qemu-devel] [PATCH 1/9] Remove stray GSO code from virtio_net Mark McLoughlin
2009-04-15 16:29 ` [Qemu-devel] [PATCH 2/9] struct iovec is now universally available Mark McLoughlin
2009-04-15 16:29 ` [Qemu-devel] [PATCH 3/9] Fix error handling in net_client_init() Mark McLoughlin
2009-04-15 16:29 ` [Qemu-devel] [PATCH 4/9] Don't fail PCI hotplug if no NIC model is supplied Mark McLoughlin
2009-04-15 16:29 ` [Qemu-devel] [PATCH 5/9] Remove some useless malloc() checking Mark McLoughlin
2009-04-15 16:29 ` [Qemu-devel] [PATCH 6/9] Remove NICInfo from e1000 and mipsnet state Mark McLoughlin
2009-04-15 16:29 ` [Qemu-devel] [PATCH 7/9] Add unregister_savevm() Mark McLoughlin
2009-04-15 16:29 ` [Qemu-devel] [PATCH 8/9] Use NICInfo::model for eepro100 savevm ID string Mark McLoughlin
2009-04-15 16:29 ` [Qemu-devel] [PATCH 9/9] Introduce VLANClientState::cleanup() Mark McLoughlin
2009-04-15 17:34 ` [Qemu-devel] " Jan Kiszka
2009-04-16 1:07 ` Marcelo Tosatti
2009-04-16 3:24 ` M. Warner Losh
2009-04-16 14:49 ` Mark McLoughlin
2009-04-16 14:52 ` [Qemu-devel] [PATCH 09/09 v2] " Mark McLoughlin
2009-04-16 14:53 ` [Qemu-devel] [PATCH 10/09] Free VLANClientState using qemu_free() Mark McLoughlin
2009-04-16 20:44 ` [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup() Marcelo Tosatti
2009-04-28 12:08 ` Paul Brook
2009-04-28 16:46 ` Anthony Liguori
2009-04-28 17:17 ` Paul Brook
2009-04-28 17:25 ` Anthony Liguori
2009-04-28 17:46 ` Paul Brook
2009-04-28 17:49 ` Anthony Liguori
2009-04-28 18:28 ` Paul Brook
2009-04-28 21:38 ` Anthony Liguori
2009-04-29 10:37 ` Paul Brook
2009-04-30 13:45 ` Avi Kivity
2009-04-30 16:02 ` Paul Brook
2009-04-30 16:20 ` Avi Kivity
2009-04-30 16:31 ` Paul Brook
2009-04-30 16:32 ` Avi Kivity
2009-04-30 16:37 ` Anthony Liguori
2009-04-30 16:41 ` Anthony Liguori [this message]
2009-04-30 16:58 ` Paul Brook
2009-04-30 17:51 ` Avi Kivity
2009-04-30 16:33 ` Anthony Liguori
2009-04-30 16:32 ` Anthony Liguori
2009-04-30 16:57 ` Blue Swirl
2009-04-30 17:11 ` Anthony Liguori
2009-04-30 17:45 ` Jan Kiszka
2009-04-30 17:48 ` Avi Kivity
2009-04-30 18:17 ` Jan Kiszka
2009-04-30 18:19 ` Avi Kivity
2009-04-30 18:22 ` Anthony Liguori
2009-04-30 17:59 ` Anthony Liguori
2009-04-30 18:10 ` Blue Swirl
2009-04-30 18:20 ` Jan Kiszka
2009-04-30 18:32 ` Anthony Liguori
2009-04-30 18:57 ` Blue Swirl
2009-04-30 18:16 ` Jan Kiszka
2009-04-29 7:36 ` Markus Armbruster
2009-04-16 14:49 ` Mark McLoughlin
2009-04-15 17:13 ` [Qemu-devel] Re: [PATCH 5/9] Remove some useless malloc() checking Jan Kiszka
2009-04-15 16:55 ` [Qemu-devel] [PATCH 2/9] struct iovec is now universally available Christoph Hellwig
2009-04-15 17:25 ` Mark McLoughlin
2009-04-15 17:27 ` Christoph Hellwig
2009-04-15 21:18 ` François Revol
2009-04-15 21:52 ` M. Warner Losh
2009-04-15 17:44 ` M. Warner Losh
2009-04-17 18:06 ` [Qemu-devel] [PATCH 1/9] Remove stray GSO code from virtio_net Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F9D4A1.7070005@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=avi@redhat.com \
--cc=markmc@redhat.com \
--cc=mtosatti@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).