From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LzaYO-0004s0-T2 for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:00:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LzaYK-0004pC-1t for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:00:12 -0400 Received: from [199.232.76.173] (port=55203 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzaYJ-0004p2-BN for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:00:07 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:38964) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LzaYI-0004zB-AF for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:00:06 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e37.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3UHxVFV030629 for ; Thu, 30 Apr 2009 11:59:31 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3UI01JI116030 for ; Thu, 30 Apr 2009 12:00:02 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3UI00k6028807 for ; Thu, 30 Apr 2009 12:00:01 -0600 Message-ID: <49F9E71F.50009@us.ibm.com> Date: Thu, 30 Apr 2009 12:59:59 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1239812969-8320-2-git-send-email-markmc@redhat.com> <200904291137.57852.paul@codesourcery.com> <49F9AB7C.7020803@redhat.com> <200904301702.32282.paul@codesourcery.com> <49F9D2B3.60707@us.ibm.com> <49F9DBCC.3030906@us.ibm.com> <49F9E3CB.4000604@web.de> In-Reply-To: <49F9E3CB.4000604@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Mark McLoughlin , Marcelo Tosatti , Markus Armbruster , qemu-devel@nongnu.org, Blue Swirl , Avi Kivity , Paul Brook Jan Kiszka wrote: > That would only allow one such pair per VM. > id basically becomes another type of vlan id. To have multiple nics, you do: -net tap,vlan=off,id=1234 -net nic,model=virtio,vlan=off,id=1234 -net tap,vlan=off,id=4321 -net nic,model=virtio,vlan=off,id=4321 And this goes back to the notion of having all device front-ends/back-ends have some sort of identifier to associate one to the other. > Why not keeping all the existing infrastructure, just locking a vlan > against becoming more than a point-to-point link once some conflicting > optimization was applied? That should be easy to implement and to > explain to the user. > I think you're suggesting the same thing as me, except you are saying make vlan=off implicit, and use vlan=XXX instead of id=XXX. We can still make vlan=off implicit, and default id=0, so that -net tap net nic,model=virtio does the right thing. However, if a user explicitly says -net tap,vlan=1 -net nic,model=virtio,vlan=1, it behaves like it used to. -- Regards, Anthony Liguori