From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lzaof-0007t4-B9 for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:17:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lzaoa-0007ik-Cp for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:17:00 -0400 Received: from [199.232.76.173] (port=40461 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzaoZ-0007i5-TJ for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:16:55 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:48473) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LzaoZ-0007Ht-CS for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:16:55 -0400 Message-ID: <49F9EB0D.1010400@web.de> Date: Thu, 30 Apr 2009 20:16:45 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1239812969-8320-2-git-send-email-markmc@redhat.com> <200904291137.57852.paul@codesourcery.com> <49F9AB7C.7020803@redhat.com> <200904301702.32282.paul@codesourcery.com> <49F9D2B3.60707@us.ibm.com> <49F9DBCC.3030906@us.ibm.com> <49F9E3CB.4000604@web.de> <49F9E71F.50009@us.ibm.com> In-Reply-To: <49F9E71F.50009@us.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigCA2369B4C9232BD6EF2EB8F0" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Mark McLoughlin , Marcelo Tosatti , Markus Armbruster , qemu-devel@nongnu.org, Blue Swirl , Avi Kivity , Paul Brook This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCA2369B4C9232BD6EF2EB8F0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Anthony Liguori wrote: > Jan Kiszka wrote: >> That would only allow one such pair per VM. >> =20 >=20 > id basically becomes another type of vlan id. To have multiple nics, > you do: >=20 > -net tap,vlan=3Doff,id=3D1234 -net nic,model=3Dvirtio,vlan=3Doff,id=3D1= 234 > -net tap,vlan=3Doff,id=3D4321 -net nic,model=3Dvirtio,vlan=3Doff,id=3D4= 321 >=20 > And this goes back to the notion of having all device > front-ends/back-ends have some sort of identifier to associate one to > the other. >=20 >> Why not keeping all the existing infrastructure, just locking a vlan >> against becoming more than a point-to-point link once some conflicting= >> optimization was applied? That should be easy to implement and to >> explain to the user. >> =20 >=20 > I think you're suggesting the same thing as me, except you are saying > make vlan=3Doff implicit, and use vlan=3DXXX instead of id=3DXXX. Look like. :) >=20 > We can still make vlan=3Doff implicit, and default id=3D0, so that -net= tap > net nic,model=3Dvirtio does the right thing. However, if a user > explicitly says -net tap,vlan=3D1 -net nic,model=3Dvirtio,vlan=3D1, it = behaves > like it used to. That's my point. And if he tries "-net tap -net nic,model=3Dvirtio -net nic", qemu will fall back to bus-like vlan. And if he tries do add the third nic during runtime, there will be a descriptive error message. That should be most elegant while not blocking optimizations (of the common case). Jan --------------enigCA2369B4C9232BD6EF2EB8F0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkn56xQACgkQniDOoMHTA+lssgCbBoNzr24OrKpzkFMjKKB1UlBy yy8AoIJjjce4BOb3noqOLSmlbMAeVAMn =AvmP -----END PGP SIGNATURE----- --------------enigCA2369B4C9232BD6EF2EB8F0--