From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LzasB-0002GO-GG for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:20:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lzas5-0002Eh-VZ for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:20:38 -0400 Received: from [199.232.76.173] (port=40516 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lzas5-0002EV-Mi for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:20:33 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:60426) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lzas5-0007rT-5B for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:20:33 -0400 Message-ID: <49F9EBEF.40808@web.de> Date: Thu, 30 Apr 2009 20:20:31 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1239812969-8320-2-git-send-email-markmc@redhat.com> <200904291137.57852.paul@codesourcery.com> <49F9AB7C.7020803@redhat.com> <200904301702.32282.paul@codesourcery.com> <49F9D2B3.60707@us.ibm.com> <49F9DBCC.3030906@us.ibm.com> <49F9E3CB.4000604@web.de> <49F9E71F.50009@us.ibm.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig55F3A91F17D4F50602ADF6D0" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Mark McLoughlin , Anthony Liguori , Marcelo Tosatti , Markus Armbruster , qemu-devel@nongnu.org, Avi Kivity , Paul Brook This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig55F3A91F17D4F50602ADF6D0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Blue Swirl wrote: > On 4/30/09, Anthony Liguori wrote: >> Jan Kiszka wrote: >>> Why not keeping all the existing infrastructure, just locking a vlan >>> against becoming more than a point-to-point link once some conflictin= g >>> optimization was applied? That should be easy to implement and to >>> explain to the user. >>> >>> >> I think you're suggesting the same thing as me, except you are saying= make >> vlan=3Doff implicit, and use vlan=3DXXX instead of id=3DXXX. >> >> We can still make vlan=3Doff implicit, and default id=3D0, so that -n= et tap net >> nic,model=3Dvirtio does the right thing. However, if a user explicitl= y says >> -net tap,vlan=3D1 -net nic,model=3Dvirtio,vlan=3D1, it behaves like it= used to. >=20 > Nice, though if there are two vlans, one specified without explicit ID > and the other with ID=3D1, the performance will be different. Uh, the second case should rather behave like the first. Only if the number vlan clients grows beyond 2, point-to-point optimizations should be disabled (unless already enabled, then adding clients should be denied= ). Jan --------------enig55F3A91F17D4F50602ADF6D0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkn56+8ACgkQniDOoMHTA+kxzgCfXwrB5xroaaONnDcwWAgO/3SB 9qQAn2klMYqDB1R3N1lJPZb9mH2tULNO =sawD -----END PGP SIGNATURE----- --------------enig55F3A91F17D4F50602ADF6D0--