From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lzb42-0000Ky-QF for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:32:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lzb3y-0000Da-T7 for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:32:54 -0400 Received: from [199.232.76.173] (port=45935 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lzb3y-0000D9-LM for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:32:50 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:42284) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lzb3y-000158-9R for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:32:50 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e5.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3UIS2vq032426 for ; Thu, 30 Apr 2009 14:28:02 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3UIWmXb146298 for ; Thu, 30 Apr 2009 14:32:48 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3UIUwCq014050 for ; Thu, 30 Apr 2009 14:30:58 -0400 Message-ID: <49F9EECE.8020301@us.ibm.com> Date: Thu, 30 Apr 2009 13:32:46 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1239812969-8320-2-git-send-email-markmc@redhat.com> <200904291137.57852.paul@codesourcery.com> <49F9AB7C.7020803@redhat.com> <200904301702.32282.paul@codesourcery.com> <49F9D2B3.60707@us.ibm.com> <49F9DBCC.3030906@us.ibm.com> <49F9E3CB.4000604@web.de> <49F9E71F.50009@us.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Mark McLoughlin , Marcelo Tosatti , Markus Armbruster , qemu-devel@nongnu.org, Jan Kiszka , Avi Kivity , Paul Brook Blue Swirl wrote: > On 4/30/09, Anthony Liguori wrote: > >> Jan Kiszka wrote: >> >> >>> That would only allow one such pair per VM. >>> >>> >>> >> id basically becomes another type of vlan id. To have multiple nics, you >> do: >> >> -net tap,vlan=off,id=1234 -net >> nic,model=virtio,vlan=off,id=1234 >> -net tap,vlan=off,id=4321 -net >> nic,model=virtio,vlan=off,id=4321 >> > > I think "off" and "id" are not descriptive enough, how about: > -net tap,vlan=pointopoint,ptop_id=4321 -net > nic,model=virtio,vlan=pointopoint,ptop_id=4321 > or vlan=none? p2p doesn't make very much sense to me personally. I agree "id" may be too generic. Maybe devid or device_id? >> I think you're suggesting the same thing as me, except you are saying make >> vlan=off implicit, and use vlan=XXX instead of id=XXX. >> >> We can still make vlan=off implicit, and default id=0, so that -net tap net >> nic,model=virtio does the right thing. However, if a user explicitly says >> -net tap,vlan=1 -net nic,model=virtio,vlan=1, it behaves like it used to. >> > > Nice, though if there are two vlans, one specified without explicit ID > and the other with ID=1, the performance will be different. > If a user mixes vlans and p2p links, then yeah, performance is going to be different. I'd like to eventually make vlan=none the default to be perfectly honest. I don't think many people depend on implicit vlan=0 so I don't think we'll really break anyone. -- Regards, Anthony Liguori