From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lzty4-0000sA-QB
	for qemu-devel@nongnu.org; Fri, 01 May 2009 10:44:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lzty0-0000no-SW
	for qemu-devel@nongnu.org; Fri, 01 May 2009 10:44:00 -0400
Received: from [199.232.76.173] (port=46939 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lzty0-0000nV-MY
	for qemu-devel@nongnu.org; Fri, 01 May 2009 10:43:56 -0400
Received: from e9.ny.us.ibm.com ([32.97.182.139]:58201)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1Lzty0-0003GI-Ab
	for qemu-devel@nongnu.org; Fri, 01 May 2009 10:43:56 -0400
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e9.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n41EX1Ur009182
	for <qemu-devel@nongnu.org>; Fri, 1 May 2009 10:33:01 -0400
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n41EhsPP119758
	for <qemu-devel@nongnu.org>; Fri, 1 May 2009 10:43:54 -0400
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n41EhsQ0005826
	for <qemu-devel@nongnu.org>; Fri, 1 May 2009 10:43:54 -0400
Message-ID: <49FB0AA8.90103@us.ibm.com>
Date: Fri, 01 May 2009 09:43:52 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3
References: <49F9FEBA.6050901@gmail.com>
In-Reply-To: <49F9FEBA.6050901@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Ahern <dsahern@gmail.com>
Cc: qemu-devel@nongnu.org

David Ahern wrote:
> Did not see a response to the last version.
>
> This patch enables TCP keepalives on VNC connections and TCP-based char
> devices.
>
> Default parameters have keep alive probes sent after 60-seconds of idle
> time. Probes are sent every 12 seconds with the connection resetting
> after 5 failed probes (ie., connection is closed if no response receive=
d
> in 60-seconds).
>
> Changes v2 -> v3
> Removed duplicate definition and fixed typo in comments.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
>
>
> david
>  =20
This patch introduces a warning:

/home/anthony/git/qemu/vnc.c:2039: warning: implicit declaration of=20
function =91enable_tcp_keepalive=92

--=20
Regards,

Anthony Liguori