From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lzu1C-00034k-Qk
	for qemu-devel@nongnu.org; Fri, 01 May 2009 10:47:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lzu17-0002zX-Qh
	for qemu-devel@nongnu.org; Fri, 01 May 2009 10:47:14 -0400
Received: from [199.232.76.173] (port=41384 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lzu17-0002zG-GA
	for qemu-devel@nongnu.org; Fri, 01 May 2009 10:47:09 -0400
Received: from wf-out-1314.google.com ([209.85.200.170]:46750)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <dsahern@gmail.com>) id 1Lzu17-0003Yz-1L
	for qemu-devel@nongnu.org; Fri, 01 May 2009 10:47:09 -0400
Received: by wf-out-1314.google.com with SMTP id 26so1820503wfd.4
	for <qemu-devel@nongnu.org>; Fri, 01 May 2009 07:47:07 -0700 (PDT)
Message-ID: <49FB0B67.5070305@gmail.com>
Date: Fri, 01 May 2009 08:47:03 -0600
From: David Ahern <dsahern@gmail.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3
References: <49F9FEBA.6050901@gmail.com> <49FB0AA8.90103@us.ibm.com>
In-Reply-To: <49FB0AA8.90103@us.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org



Anthony Liguori wrote:
> David Ahern wrote:
>> Did not see a response to the last version.
>>
>> This patch enables TCP keepalives on VNC connections and TCP-based char
>> devices.
>>
>> Default parameters have keep alive probes sent after 60-seconds of idle
>> time. Probes are sent every 12 seconds with the connection resetting
>> after 5 failed probes (ie., connection is closed if no response received
>> in 60-seconds).
>>
>> Changes v2 -> v3
>> Removed duplicate definition and fixed typo in comments.
>>
>> Signed-off-by: David Ahern <dsahern@gmail.com>
>>
>>
>> david
>>   
> This patch introduces a warning:
> 
> /home/anthony/git/qemu/vnc.c:2039: warning: implicit declaration of
> function ‘enable_tcp_keepalive’
> 

Missed that. Forgot to add net.h to vnc.c.

Before I re-send a patch, what's the feeling regarding enabling this all
the time versus a command line option to control it?

david