From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lzv2d-0000mo-HY
	for qemu-devel@nongnu.org; Fri, 01 May 2009 11:52:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lzv2Z-0000m3-2k
	for qemu-devel@nongnu.org; Fri, 01 May 2009 11:52:47 -0400
Received: from [199.232.76.173] (port=51568 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lzv2Y-0000m0-Rt
	for qemu-devel@nongnu.org; Fri, 01 May 2009 11:52:42 -0400
Received: from mx2.redhat.com ([66.187.237.31]:39273)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1Lzv2Y-0004v1-D0
	for qemu-devel@nongnu.org; Fri, 01 May 2009 11:52:42 -0400
Message-ID: <49FB1AC3.2040804@redhat.com>
Date: Fri, 01 May 2009 18:52:35 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3
References: <49F9FEBA.6050901@gmail.com>	<20090501113204.GA10763@amd.home.annexia.org>	<49FAEFDD.2070002@gmail.com>
	<20090501152312.GH13308@redhat.com>
In-Reply-To: <20090501152312.GH13308@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, "Richard W.M. Jones" <rjones@redhat.com>, David Ahern <dsahern@gmail.com>

Daniel P. Berrange wrote:
> You don't neccessarily always get a different IP for VPN connections,
> as administrators may well choose to give users a fixed IP for their
> VPN client. I'm not entirely against keepalives, but I thing making
> it drop the connection after a mere 60 seconds is way too quick, if this
> is enabled by default. I'd be more inclined to just have it use the
> kernel defaults for timeouts
>   

That's around two hours.

I understand the wariness when it comes to dropping connections, but vnc 
is a reconnectable protocol; it isn't like you lose any data.  If the 
connection drops for two minutes it is useless anyway.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.