From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lzv7E-00029w-Lr for qemu-devel@nongnu.org; Fri, 01 May 2009 11:57:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lzv7A-00028k-4l for qemu-devel@nongnu.org; Fri, 01 May 2009 11:57:32 -0400 Received: from [199.232.76.173] (port=36833 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lzv7A-00028h-0H for qemu-devel@nongnu.org; Fri, 01 May 2009 11:57:28 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:32957) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lzv79-0005XV-JD for qemu-devel@nongnu.org; Fri, 01 May 2009 11:57:27 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n41FrVeb029936 for ; Fri, 1 May 2009 11:53:31 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n41FvQmR159868 for ; Fri, 1 May 2009 11:57:26 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n41FvP5t010492 for ; Fri, 1 May 2009 11:57:26 -0400 Message-ID: <49FB1BE4.30207@us.ibm.com> Date: Fri, 01 May 2009 10:57:24 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3 References: <49F9FEBA.6050901@gmail.com> <49FB0B67.5070305@gmail.com> <49FB0C57.9020501@us.ibm.com> <200905011616.13164.paul@codesourcery.com> In-Reply-To: <200905011616.13164.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org, David Ahern Paul Brook wrote: > On Friday 01 May 2009, Anthony Liguori wrote: > >> David Ahern wrote: >> >>> Missed that. Forgot to add net.h to vnc.c. >>> >>> Before I re-send a patch, what's the feeling regarding enabling this all >>> the time versus a command line option to control it? >>> >>> david >>> >> I'm on the fence. It's not something I think is extremely common and it >> seems like we're going to great lengths to fix up one persons broken >> configuration. >> > > I'm wary of enabling this by default. As someone else mentioned, having your > TCP console connections spontaneously combust after 60 seconds can be > somewhat surprising. > > An option seems reasonable enough. We already have this for nodelay. > I don't think an option is very useful. If you lose your connection and now have a bunch of orphan connections, it's too late to have the foresight to have used an option on startup. In that case, it would be much better to just be able to close existing connections. I think there's a very, very small number of people that would have the foresight to always use keepalive=60 or whatever the option would be. -- Regards, Anthony Liguori