From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M02jG-0004vh-QQ for qemu-devel@nongnu.org; Fri, 01 May 2009 20:05:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M02jC-0004pr-3C for qemu-devel@nongnu.org; Fri, 01 May 2009 20:05:18 -0400 Received: from [199.232.76.173] (port=38758 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M02jB-0004pf-UJ for qemu-devel@nongnu.org; Fri, 01 May 2009 20:05:13 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:46839) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M02jA-00084c-Sb for qemu-devel@nongnu.org; Fri, 01 May 2009 20:05:13 -0400 Message-ID: <49FB8E33.3040802@web.de> Date: Sat, 02 May 2009 02:05:07 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20090501211717.24514.23246.stgit@mchn012c.ww002.siemens.net> <20090501211721.24514.45545.stgit@mchn012c.ww002.siemens.net> <200905020052.07059.paul@codesourcery.com> In-Reply-To: <200905020052.07059.paul@codesourcery.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig59DD13D78A1D552773EC9770" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 7/8] Introduce reset notifier order List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: Anthony Liguori , qemu-devel@nongnu.org, Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig59DD13D78A1D552773EC9770 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Paul Brook wrote: > On Friday 01 May 2009, Jan Kiszka wrote: >> Add the parameter 'order' to qemu_register_reset and sort callbacks on= >> registration. On system reset, callbacks with lower order will be >> invoked before those with higher order. Update all existing users to t= he >> standard order 0. >> >> Note: At least for x86, the existing users seem to assume that handler= s >> are called in their registration order. Therefore, the patch preserves= >> this property. If someone feels bored, (s)he could try to identify thi= s >> dependency and express it properly on callback registration. >=20 > Why do we need this? Why isn't creation order good enough? At latest when properly deregistering reset handlers again on device unplug, the registration order is no longer a static thing, manifested in the code organization - which can also break due to refactoring, BTW. Jan --------------enig59DD13D78A1D552773EC9770 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkn7jjcACgkQniDOoMHTA+nIiACfb+xnv+Gi0F5T37RhxpFHM4gR AgkAnRVFTJG5LYA3PYSrRH6jb2lvgXfu =zxZD -----END PGP SIGNATURE----- --------------enig59DD13D78A1D552773EC9770--