From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M02mA-0007c0-32 for qemu-devel@nongnu.org; Fri, 01 May 2009 20:08:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M02m5-0007a0-6W for qemu-devel@nongnu.org; Fri, 01 May 2009 20:08:17 -0400 Received: from [199.232.76.173] (port=54339 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M02m5-0007Zr-1p for qemu-devel@nongnu.org; Fri, 01 May 2009 20:08:13 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:48118) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M02m4-0000Dt-EV for qemu-devel@nongnu.org; Fri, 01 May 2009 20:08:12 -0400 Message-ID: <49FB8EEB.1050208@web.de> Date: Sat, 02 May 2009 02:08:11 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20090501211717.24514.23246.stgit@mchn012c.ww002.siemens.net> <49FB7C81.80101@web.de> In-Reply-To: <49FB7C81.80101@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: jan.kiszka@web.de Subject: [Qemu-devel] [PATCH 9/8] kvm: x86: Save/restore KVM-specific CPU states List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Avi Kivity , qemu-devel@nongnu.org Save and restore all so far neglected KVM-specific CPU states. Handling the TSC stabilizes migration in KVM mode. The interrupt_bitmap and mp_state are currently unused, but will become relevant for in-kernel irqchip support. By including proper saving/restoring already, we avoid having to increment CPU_SAVE_VERSION later on once again. Signed-off-by: Jan Kiszka --- kvm-all.c | 20 ++++++++++++++++++++ kvm.h | 3 +++ target-i386/cpu.h | 3 ++- target-i386/kvm.c | 10 ++++++++++ target-i386/machine.c | 16 ++++++++++++++-- 5 files changed, 49 insertions(+), 3 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 2ac5129..f17055f 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -181,6 +181,26 @@ err: return ret; } +int kvm_put_mp_state(CPUState *env) +{ + struct kvm_mp_state mp_state = { .mp_state = env->mp_state }; + + return kvm_vcpu_ioctl(env, KVM_SET_MP_STATE, &mp_state); +} + +int kvm_get_mp_state(CPUState *env) +{ + struct kvm_mp_state mp_state; + int ret; + + ret = kvm_vcpu_ioctl(env, KVM_GET_MP_STATE, &mp_state); + if (ret < 0) { + return ret; + } + env->mp_state = mp_state.mp_state; + return 0; +} + int kvm_sync_vcpus(void) { CPUState *env; diff --git a/kvm.h b/kvm.h index 6e0589a..8256eb6 100644 --- a/kvm.h +++ b/kvm.h @@ -72,6 +72,9 @@ int kvm_vm_ioctl(KVMState *s, int type, ...); int kvm_vcpu_ioctl(CPUState *env, int type, ...); +int kvm_get_mp_state(CPUState *env); +int kvm_put_mp_state(CPUState *env); + /* Arch specific hooks */ int kvm_arch_post_run(CPUState *env, struct kvm_run *run); diff --git a/target-i386/cpu.h b/target-i386/cpu.h index c6bca94..eaa623c 100644 --- a/target-i386/cpu.h +++ b/target-i386/cpu.h @@ -669,6 +669,7 @@ typedef struct CPUX86State { /* For KVM */ uint64_t interrupt_bitmap[256 / 64]; + uint32_t mp_state; /* in order to simplify APIC support, we leave this pointer to the user */ @@ -837,7 +838,7 @@ static inline int cpu_get_time_fast(void) #define cpu_signal_handler cpu_x86_signal_handler #define cpu_list x86_cpu_list -#define CPU_SAVE_VERSION 8 +#define CPU_SAVE_VERSION 9 /* MMU modes definitions */ #define MMU_MODE0_SUFFIX _kernel diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 2de8b81..f65ae00 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -43,6 +43,8 @@ int kvm_arch_init_vcpu(CPUState *env) uint32_t limit, i, j, cpuid_i; uint32_t unused; + env->mp_state = KVM_MP_STATE_UNINITIALIZED; + cpuid_i = 0; cpu_x86_cpuid(env, 0, 0, &limit, &unused, &unused, &unused); @@ -565,6 +567,10 @@ int kvm_arch_put_registers(CPUState *env) if (ret < 0) return ret; + ret = kvm_put_mp_state(env); + if (ret < 0) + return ret; + return 0; } @@ -588,6 +594,10 @@ int kvm_arch_get_registers(CPUState *env) if (ret < 0) return ret; + ret = kvm_get_mp_state(env); + if (ret < 0) + return ret; + return 0; } diff --git a/target-i386/machine.c b/target-i386/machine.c index 4fc7335..e1ba0d5 100644 --- a/target-i386/machine.c +++ b/target-i386/machine.c @@ -149,6 +149,12 @@ void cpu_save(QEMUFile *f, void *opaque) qemu_put_be64s(f, &env->mtrr_var[i].base); qemu_put_be64s(f, &env->mtrr_var[i].mask); } + + for (i = 0; i < sizeof(env->interrupt_bitmap)/8; i++) { + qemu_put_be64s(f, &env->interrupt_bitmap[i]); + } + qemu_put_be64s(f, &env->tsc); + qemu_put_be32s(f, &env->mp_state); } #ifdef USE_X86LDOUBLE @@ -183,8 +189,7 @@ int cpu_load(QEMUFile *f, void *opaque, int version_id) uint16_t fpus, fpuc, fptag, fpregs_format; int32_t a20_mask; - if (version_id != 3 && version_id != 4 && version_id != 5 - && version_id != 6 && version_id != 7 && version_id != 8) + if (version_id < 3 || version_id > CPU_SAVE_VERSION) return -EINVAL; for(i = 0; i < CPU_NB_REGS; i++) qemu_get_betls(f, &env->regs[i]); @@ -328,6 +333,13 @@ int cpu_load(QEMUFile *f, void *opaque, int version_id) qemu_get_be64s(f, &env->mtrr_var[i].mask); } } + if (version_id >= 9) { + for (i = 0; i < sizeof(env->interrupt_bitmap)/8; i++) { + qemu_get_be64s(f, &env->interrupt_bitmap[i]); + } + qemu_get_be64s(f, &env->tsc); + qemu_get_be32s(f, &env->mp_state); + } /* XXX: ensure compatiblity for halted bit ? */ /* XXX: compute redundant hflags bits */