From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M0Upl-0001wl-VZ
	for qemu-devel@nongnu.org; Sun, 03 May 2009 02:05:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M0Upg-0001pw-Pz
	for qemu-devel@nongnu.org; Sun, 03 May 2009 02:05:53 -0400
Received: from [199.232.76.173] (port=38726 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M0Upg-0001po-K1
	for qemu-devel@nongnu.org; Sun, 03 May 2009 02:05:48 -0400
Received: from mx2.redhat.com ([66.187.237.31]:47046)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1M0Upg-0007HC-2S
	for qemu-devel@nongnu.org; Sun, 03 May 2009 02:05:48 -0400
Message-ID: <49FD341C.8030205@redhat.com>
Date: Sun, 03 May 2009 09:05:16 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Import KVM headers including Makefile and
	import script
References: <1241298173-20668-1-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1241298173-20668-1-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Hollis Blanchard <hollisb@us.ibm.com>

Anthony Liguori wrote:
> These are the headers from Linux 2.6.29 that have been modified to work under
> QEMU.  This includes the necessary scripts to generate the headers from the
> original Linux source tree.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  configure                      |    7 +-
>  include/HEAD                   |    1 +
>  include/Makefile               |   26 ++
>  include/README                 |    6 +
>  include/asm-powerpc/kvm.h      |   55 ++++
>  include/asm-powerpc/kvm_para.h |   37 +++
>  include/asm-x86/kvm.h          |  218 ++++++++++++++++
>  include/asm-x86/kvm_para.h     |  147 +++++++++++
>  include/fixup.sed              |   11 +
>  include/linux/kvm.h            |  533 ++++++++++++++++++++++++++++++++++++++++
>  include/linux/kvm_para.h       |   44 ++++
>   

Can we put them under kvm/, as include/ looks like a generic include 
directory, which this isn't.  Also, this generates a gratuitous conflict 
with qemu-kvm.git, and we have enough of those already.

I also suggest using arch/*/include/asm as a way of avoiding the 
symlink, instead of the extra hack in fixup.sed.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.