From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M0YZp-0001vu-Fb
	for qemu-devel@nongnu.org; Sun, 03 May 2009 06:05:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M0YZi-0001up-Hb
	for qemu-devel@nongnu.org; Sun, 03 May 2009 06:05:38 -0400
Received: from [199.232.76.173] (port=48122 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M0YZg-0001ue-5c
	for qemu-devel@nongnu.org; Sun, 03 May 2009 06:05:33 -0400
Received: from mx2.redhat.com ([66.187.237.31]:44710)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1M0YZf-0003se-EG
	for qemu-devel@nongnu.org; Sun, 03 May 2009 06:05:31 -0400
Message-ID: <49FD6C67.8000107@redhat.com>
Date: Sun, 03 May 2009 13:05:27 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <20090501211717.24514.23246.stgit@mchn012c.ww002.siemens.net>
	<20090501211720.24514.67620.stgit@mchn012c.ww002.siemens.net>
In-Reply-To: <20090501211720.24514.67620.stgit@mchn012c.ww002.siemens.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 4/8] kvm: Rework dirty bitmap
	synchronization
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Jan Kiszka wrote:
> Extend kvm_physical_sync_dirty_bitmap() so that is can sync across
> multiple slots. Useful for updating the whole dirty log during
> migration. Moreover, properly pass down errors the whole call chain.
>
>  
> -void cpu_physical_sync_dirty_bitmap(target_phys_addr_t start_addr, target_phys_addr_t end_addr);
> +int cpu_physical_sync_dirty_bitmap(target_phys_addr_t start_addr,
> +                                   target_phys_addr_t end_addr);
>  
>   

This is defined in terms of physical addresses, but in patch 5, you

> @@ -3248,13 +3248,18 @@ static int ram_save_live(QEMUFile *f, int stage, void *opaque)
>  {
>      ram_addr_t addr;
>  
> +    if (cpu_physical_sync_dirty_bitmap(0, last_ram_offset) != 0) {
> +        qemu_file_set_error(f);
> +        return 0;
> +    }
> +
>     

Which is in terms of ram addresses; so this will fail with large memory, 
where the last phys address is larger than the last ram address.

Maybe this can be as easy as passing -1 for the end address.  But in 
this case I suggest adding a helper to sync all of memory instead.

-- 
error compiling committee.c: too many arguments to function