From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M0e5J-0001vt-Sd for qemu-devel@nongnu.org; Sun, 03 May 2009 11:58:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M0e5F-0001rJ-Iq for qemu-devel@nongnu.org; Sun, 03 May 2009 11:58:33 -0400 Received: from [199.232.76.173] (port=54441 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M0e5F-0001rE-Ao for qemu-devel@nongnu.org; Sun, 03 May 2009 11:58:29 -0400 Received: from mx2.redhat.com ([66.187.237.31]:54638) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M0e5E-00081v-OP for qemu-devel@nongnu.org; Sun, 03 May 2009 11:58:29 -0400 Message-ID: <49FDBF20.1020207@redhat.com> Date: Sun, 03 May 2009 18:58:24 +0300 From: Avi Kivity MIME-Version: 1.0 References: <20090501211717.24514.23246.stgit@mchn012c.ww002.siemens.net> <20090501211721.24514.10182.stgit@mchn012c.ww002.siemens.net> In-Reply-To: <20090501211721.24514.10182.stgit@mchn012c.ww002.siemens.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 8/8] kvm: Rework VCPU reset List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , qemu-devel@nongnu.org Jan Kiszka wrote: > Use standard callback with highest order to synchronize VCPU on reset > after all device callbacks were execute. This allows to remove the > special kvm hook in qemu_system_reset. > Is this needed for the lapic reset callback? If so, we can express the dependency explicitly rather than with a priority, by having cpu reset notifiers invoked when the cpu is reset. In the case of the lapic, I don't think we need an abstract mechanism; the lapic is part of the cpu, not some random device. Maybe we should even save/load it as part of the cpu. -- error compiling committee.c: too many arguments to function