From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M0sro-0001oR-2P for qemu-devel@nongnu.org; Mon, 04 May 2009 03:45:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M0srj-0001kF-E7 for qemu-devel@nongnu.org; Mon, 04 May 2009 03:45:35 -0400 Received: from [199.232.76.173] (port=45424 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M0srj-0001jv-8l for qemu-devel@nongnu.org; Mon, 04 May 2009 03:45:31 -0400 Received: from mx20.gnu.org ([199.232.41.8]:14070) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M0sri-0008DI-NA for qemu-devel@nongnu.org; Mon, 04 May 2009 03:45:30 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M0srg-0007pc-Dh for qemu-devel@nongnu.org; Mon, 04 May 2009 03:45:28 -0400 Message-ID: <49FE9CFD.4060308@web.de> Date: Mon, 04 May 2009 09:45:01 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 7/8] Introduce reset notifier order References: <20090501211717.24514.23246.stgit@mchn012c.ww002.siemens.net> <200905020052.07059.paul@codesourcery.com> <49FB8E33.3040802@web.de> <200905020134.56943.paul@codesourcery.com> In-Reply-To: <200905020134.56943.paul@codesourcery.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig8985FD7D619BAAB754A7322A" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: Anthony Liguori , qemu-devel@nongnu.org, Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8985FD7D619BAAB754A7322A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Paul Brook wrote: > On Saturday 02 May 2009, Jan Kiszka wrote: >> Paul Brook wrote: >>> On Friday 01 May 2009, Jan Kiszka wrote: >>>> Add the parameter 'order' to qemu_register_reset and sort callbacks = on >>>> registration. On system reset, callbacks with lower order will be >>>> invoked before those with higher order. Update all existing users to= the >>>> standard order 0. >>>> >>>> Note: At least for x86, the existing users seem to assume that handl= ers >>>> are called in their registration order. Therefore, the patch preserv= es >>>> this property. If someone feels bored, (s)he could try to identify t= his >>>> dependency and express it properly on callback registration. >>> Why do we need this? Why isn't creation order good enough? >> At latest when properly deregistering reset handlers again on device >> unplug, the registration order is no longer a static thing, manifested= >> in the code organization - which can also break due to refactoring, BT= W. >=20 > I'm afraid I can't make any sense of this. What exactly are you trying = to=20 > solve? Thinking about it again, device hot-plugging was a bad example as its natural order usually also ensures the right reset order. The problem I'm trying to solve are tricky dependencies on x86 between CPU, APIC, and KVM's VCPU. But I got an idea how to solve it differently.= Jan --------------enig8985FD7D619BAAB754A7322A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkn+nQMACgkQniDOoMHTA+kLvgCfQua8OGKrP+IQL3qgJIgyo6FZ THcAn0aQUH1wz97IkvIRbhb+buclpf3L =xFEv -----END PGP SIGNATURE----- --------------enig8985FD7D619BAAB754A7322A--