From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M0yNr-0002VD-3O for qemu-devel@nongnu.org; Mon, 04 May 2009 09:39:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M0yNm-0002Qj-Mr for qemu-devel@nongnu.org; Mon, 04 May 2009 09:39:02 -0400 Received: from [199.232.76.173] (port=44588 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M0yNm-0002QZ-FJ for qemu-devel@nongnu.org; Mon, 04 May 2009 09:38:58 -0400 Received: from mx2.redhat.com ([66.187.237.31]:48476) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M0yNl-00086a-Vu for qemu-devel@nongnu.org; Mon, 04 May 2009 09:38:58 -0400 Message-ID: <49FEEFC4.6060008@redhat.com> Date: Mon, 04 May 2009 16:38:12 +0300 From: Avi Kivity MIME-Version: 1.0 References: <49FE0E97.30602@codemonkey.ws> <200905041329.30824.arnd@arndb.de> <49FEEBDD.3090102@codemonkey.ws> In-Reply-To: <49FEEBDD.3090102@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC] Bring in all the Linux headers we depend on in QEMU List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: "qemu-devel@nongnu.org" , Arnd Bergmann , kvm-devel Anthony Liguori wrote: >>> >> >> I don't see the need to copy all the core headers. These should have >> been working for ages, and hardly ever see changes that are relevant >> to kvm. > > If we want to use virtio_*.h instead of duplicating the copies as we > are now, then we need all of the core headers too or else it won't be > able to compile on systems that do not have Linux libc headers (like > win32). qemu provides virtio, it doesn't consume it. We can merge the virtio headers and remove the linuxisms. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.