From: Paolo Bonzini <pbonzini@redhat.com>
To: Geoffrey McRae <geoff@hostfission.com>
Cc: Christian Schoenebeck <qemu_oss@crudebyte.com>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v5 1/1] audio/jack: fix use after free segfault
Date: Fri, 21 Aug 2020 15:13:56 +0200 [thread overview]
Message-ID: <49a9b5f5-d1df-b6fb-d238-7c9e8d2aeb6c@redhat.com> (raw)
In-Reply-To: <a165417b4d27c7fbce404e81f6c38cda@hostfission.com>
On 21/08/20 13:28, Geoffrey McRae wrote:
>
>> My suggestion is to work towards protecting the audio code with its own
>> mutex(es) and ignore the existence of the BQL for subsystems that can do
>> so (audio is a prime candidate). Also please add comments to
>> audio_int.h about which functions are called from other threads than the
>> QEMU main thread.
>
> Ok, so to get back on topic, what exactly is the best way forward to fix
> this issue in this patchset? Should I be managing a local mutex instead?
I think adding a local mutex for audio stuff would be best, if it's not
too hard.
Paolo
prev parent reply other threads:[~2020-08-21 13:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 6:29 [PATCH v5 0/1] audio/jack: fix use after free segfault Geoffrey McRae
2020-08-19 6:29 ` [PATCH v5 1/1] " Geoffrey McRae
2020-08-19 15:21 ` Christian Schoenebeck
2020-08-19 15:27 ` Geoffrey McRae
2020-08-20 5:37 ` Gerd Hoffmann
2020-08-20 10:06 ` Christian Schoenebeck
2020-08-20 10:54 ` Paolo Bonzini
2020-08-20 12:00 ` Christian Schoenebeck
2020-08-21 13:13 ` Paolo Bonzini
2020-08-26 13:48 ` PTHREAD_MUTEX_ERRORCHECK and fork() Christian Schoenebeck
2020-08-21 11:12 ` recursive locks (in general) Christian Schoenebeck
2020-08-21 13:08 ` Paolo Bonzini
2020-08-21 15:25 ` Christian Schoenebeck
2020-08-21 11:28 ` [PATCH v5 1/1] audio/jack: fix use after free segfault Geoffrey McRae
2020-08-21 13:13 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a9b5f5-d1df-b6fb-d238-7c9e8d2aeb6c@redhat.com \
--to=pbonzini@redhat.com \
--cc=geoff@hostfission.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).