From: Richard Henderson <richard.henderson@linaro.org>
To: matheus.ferst@eldorado.org.br, qemu-devel@nongnu.org,
qemu-ppc@nongnu.org
Cc: clg@kaod.org, danielhb413@gmail.com, david@gibson.dropbear.id.au,
groug@kaod.org
Subject: Re: [PATCH 06/12] target/ppc: declare xscvspdpn helper with call flags
Date: Tue, 17 May 2022 09:50:11 -0700 [thread overview]
Message-ID: <49ac96ee-fa28-7473-c685-17b725f1d411@linaro.org> (raw)
In-Reply-To: <20220517123929.284511-7-matheus.ferst@eldorado.org.br>
On 5/17/22 05:39, matheus.ferst@eldorado.org.br wrote:
> -uint64_t helper_xscvspdpn(CPUPPCState *env, uint64_t xb)
> +uint64_t helper_XSCVSPDPN(uint64_t xb)
> {
> return helper_todouble(xb >> 32);
> }
Ideally, this helper would not exist and you'd just use helper_todouble...
> +bool trans_XSCVSPDPN(DisasContext *ctx, arg_XX2 *a)
> +{
> + TCGv_i64 tmp;
> +
> + REQUIRE_INSNS_FLAGS2(ctx, VSX207);
> + REQUIRE_VSX(ctx);
> +
> + tmp = tcg_temp_new_i64();
> + get_cpu_vsr(tmp, a->xb, true);
... and here, you'd load the correct i32 value from VsrW(0) directly instead of loading an
i64 value followed by a shift.
But this is still an improvement so,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-05-17 17:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 12:39 [PATCH 00/12] Change helper declarations to use call flags matheus.ferst
2022-05-17 12:39 ` [PATCH 01/12] target/ppc: declare darn32/darn64 helpers with TCG_CALL_NO_RWG matheus.ferst
2022-05-17 16:30 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 02/12] target/ppc: use TCG_CALL_NO_RWG in vector helpers without env matheus.ferst
2022-05-17 16:31 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 03/12] target/ppc: use TCG_CALL_NO_RWG in BCD helpers matheus.ferst
2022-05-17 16:32 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 04/12] target/ppc: use TCG_CALL_NO_RWG in VSX helpers without env matheus.ferst
2022-05-17 16:32 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 05/12] target/ppc: Use TCG_CALL_NO_RWG_SE in fsel helper matheus.ferst
2022-05-17 16:43 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 06/12] target/ppc: declare xscvspdpn helper with call flags matheus.ferst
2022-05-17 16:50 ` Richard Henderson [this message]
2022-05-17 12:39 ` [PATCH 07/12] target/ppc: declare xvxsigsp " matheus.ferst
2022-05-17 17:30 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 08/12] target/ppc: declare xxextractuw and xxinsertw helpers " matheus.ferst
2022-05-17 17:32 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 09/12] target/ppc: introduce do_va_helper matheus.ferst
2022-05-17 17:33 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 10/12] target/ppc: declare vmsum[um]bm helpers with call flags matheus.ferst
2022-05-17 17:34 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 11/12] target/ppc: declare vmsumuhm helper " matheus.ferst
2022-05-17 17:37 ` Richard Henderson
2022-05-17 17:38 ` Richard Henderson
2022-05-17 12:39 ` [PATCH 12/12] target/ppc: declare vmsumshm " matheus.ferst
2022-05-17 17:40 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ac96ee-fa28-7473-c685-17b725f1d411@linaro.org \
--to=richard.henderson@linaro.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).