From: Richard Henderson <richard.henderson@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: iii@linux.ibm.com, deller@gmx.de, qemu-stable@nongnu.org
Subject: Re: [PATCH 3/6] linux-user: Adjust brk for load_bias
Date: Thu, 17 Aug 2023 17:17:55 -0700 [thread overview]
Message-ID: <49adae1c-1f8f-31c6-bd6f-e63ffc236d41@linaro.org> (raw)
In-Reply-To: <6fd3fa16-c8d7-adee-c90c-90e6dda68673@tls.msk.ru>
On 8/17/23 09:04, Michael Tokarev wrote:
> 16.08.2023 21:14, Richard Henderson wrote:
>> PIE executables are usually linked at offset 0 and are
>> relocated somewhere during load. The hiaddr needs to
>> be adjusted to keep the brk next to the executable.
>>
>> Cc: qemu-stable@nongnu.org
>> Fixes: 1f356e8c013 ("linux-user: Adjust initial brk when interpreter is close to
>> executable")
>
> FWIW, 1f356e8c013 is v8.1.0-rc2-86, - why did you Cc qemu-stable@?
>
> If this "Adjust brk for load_bias" fix isn't supposed to be part of 8.1.0 release,
> sure thing I'll pick it up for stable-8.1, but it looks like it should be in 8.1.0.
>
> Or are you saying 1f356e8c013 should be picked for stable-8.0, together with this one?
>
> (We're yet to decide if stable-8.0 should have any recent linux-user changes).
This has missed 8.1.0-rc4 and therefore will not be in 8.1.0.
I have tagged it stable for stable-8.1 for 8.1.1.
r~
next prev parent reply other threads:[~2023-08-18 0:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 18:14 [PATCH 0/6] linux-user: Rewrite open_self_maps Richard Henderson
2023-08-16 18:14 ` [PATCH 1/6] util/selfmap: Use dev_t and ino_t in MapInfo Richard Henderson
2023-08-17 8:52 ` Philippe Mathieu-Daudé
2023-08-16 18:14 ` [PATCH 2/6] linux-user: Use walk_memory_regions for open_self_maps Richard Henderson
2023-08-16 18:14 ` [PATCH 3/6] linux-user: Adjust brk for load_bias Richard Henderson
2023-08-17 8:53 ` Philippe Mathieu-Daudé
2023-08-18 0:16 ` Richard Henderson
2023-08-17 16:04 ` Michael Tokarev
2023-08-18 0:17 ` Richard Henderson [this message]
2024-11-26 7:11 ` [PATCH 3/6] linux-user: Adjust brk for load_bias [regression] Dominique MARTINET
2024-11-26 9:24 ` Ilya Leoshkevich
2024-11-26 9:29 ` Dominique MARTINET
2023-08-16 18:14 ` [PATCH 4/6] linux-user: Show heap address in /proc/pid/maps Richard Henderson
2023-08-21 12:07 ` Philippe Mathieu-Daudé
2023-08-16 18:14 ` [PATCH 5/6] linux-user: Remove ELF_START_MMAP and image_info.start_mmap Richard Henderson
2023-08-17 9:00 ` Philippe Mathieu-Daudé
2023-08-18 0:19 ` Richard Henderson
2023-08-18 0:35 ` Warner Losh
2023-08-16 18:14 ` [PATCH 6/6] linux-user: Show vdso address in /proc/pid/maps Richard Henderson
2023-08-21 12:07 ` Philippe Mathieu-Daudé
2023-08-16 22:25 ` [PATCH 0/6] linux-user: Rewrite open_self_maps Helge Deller
2023-08-17 17:08 ` Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49adae1c-1f8f-31c6-bd6f-e63ffc236d41@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=iii@linux.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).