From: Paolo Bonzini <pbonzini@redhat.com>
To: "Claudio Fontana" <cfontana@suse.de>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>, kvm@vger.kernel.org
Subject: Re: [PATCH 1/3] accel: Only include TCG stubs in user-mode only builds
Date: Mon, 9 Nov 2020 11:48:42 +0100 [thread overview]
Message-ID: <49ae582b-1b4d-9a0e-118c-fb4bcb714bdd@redhat.com> (raw)
In-Reply-To: <e9837717-b010-077e-2d68-0f03300793c4@suse.de>
On 09/11/20 10:55, Claudio Fontana wrote:
> Ciao Philippe,
>
> I thought that the pattern used by Paolo was, recurse always, and put
> the check inside the recursed dir meson.build . Paolo did you indeed
> intend meson use this way?
Generally yeah, I preferred to recurse always. In this specific case,
however, an even bigger qualm with the patch is that the patch content
does not match the commit message.
I also don't understand why it's useful, because patch 2 makes
everything conditional on CONFIG_SOFTMMU.
Paolo
next prev parent reply other threads:[~2020-11-09 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 9:45 [PATCH 0/3] accel: Remove system-mode stubs from user-mode builds Philippe Mathieu-Daudé
2020-11-09 9:45 ` [PATCH 1/3] accel: Only include TCG stubs in user-mode only builds Philippe Mathieu-Daudé
2020-11-09 9:55 ` Claudio Fontana
2020-11-09 10:48 ` Paolo Bonzini [this message]
2020-11-09 9:45 ` [PATCH 2/3] accel/stubs: Restrict system-mode emulation stubs Philippe Mathieu-Daudé
2020-11-09 9:56 ` Claudio Fontana
2020-11-09 9:45 ` [PATCH 3/3] accel/stubs: Simplify kvm-stub.c Philippe Mathieu-Daudé
2020-11-09 10:50 ` [PATCH 0/3] accel: Remove system-mode stubs from user-mode builds Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ae582b-1b4d-9a0e-118c-fb4bcb714bdd@redhat.com \
--to=pbonzini@redhat.com \
--cc=cfontana@suse.de \
--cc=f4bug@amsat.org \
--cc=kvm@vger.kernel.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).