From: "Kambalin, Sergey" <sergey.kambalin@auriga.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Sergey Kambalin" <serg.oker@gmail.com>
Cc: "qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] Prepare bcm properties for videocore 4
Date: Wed, 31 May 2023 15:47:37 +0000 [thread overview]
Message-ID: <49b0ba578bfb45f1be23f7608845d823@auriga.com> (raw)
In-Reply-To: <29192acf-0876-e14e-1331-45260cb179c3@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1988 bytes --]
Hello!
Thank you guys for clarifications!
> Are the VC4 properties supposed to be present on
> all our existing raspi models? (i.e. is this a bug
> fix for our existing models rather than stuff we only
> want on the new raspi4b?)
Yes, they're needed to support RPI4 work. And I think cannot be considered as a bug fix.
So I'm going to send one patch to replace the magic values with named constants.
And then I'm going to spend some time to slice the entire rpi4 machine to series of small patches.
Am I understand it right that each patch in the set must pass all the tests?
________________________________
От: Philippe Mathieu-Daudé <philmd@linaro.org>
Отправлено: 30 мая 2023 г. 17:02:00
Кому: Kambalin, Sergey; Peter Maydell; Sergey Kambalin
Копия: qemu-arm@nongnu.org; qemu-devel@nongnu.org
Тема: Re: [PATCH] Prepare bcm properties for videocore 4
On 30/5/23 15:00, Kambalin, Sergey wrote:
> Got it! Thanks!
>
> I'll split this one to three patches:
> 1) replace magic numbers with named constants (refactoring)
>
> 2) add new properties for VC 4
>
> 3) Add some unit tests to check the newly added properties via mailbox
>
>
> Is it OK?
This looks good. Try to imagine sitting on the other side, where
developers will review your code. Usually the simplest the better,
even dumb patches, since there is no risk for doubt. Don't be afraid
to post many small patches.
Personally I'd do:
- import Linux definitions
- replace current magic values with imported Linux defs
- add GET_CLOCKS property
- add GET_THROTTLED property
- add FRAMEBUFFER properties
- add GPIO properties
- add VCHIQ property
Look at do_test_arm_raspi*() in tests/avocado/boot_linux_console.py,
you could add newer kernels which use the properties you added.
> (Sorry for wasting your time by inappropriate patches - this is my first
> experience with OSS)
So far you are doing great!
Thanks,
Phil.
[-- Attachment #2: Type: text/html, Size: 3774 bytes --]
next prev parent reply other threads:[~2023-05-31 15:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 19:14 [PATCH] Prepare bcm properties for videocore 4 Sergey Kambalin
2023-05-30 12:12 ` Peter Maydell
2023-05-30 13:00 ` Kambalin, Sergey
2023-05-30 13:18 ` Peter Maydell
2023-05-30 14:02 ` Philippe Mathieu-Daudé
2023-05-31 15:47 ` Kambalin, Sergey [this message]
2023-05-31 16:49 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49b0ba578bfb45f1be23f7608845d823@auriga.com \
--to=sergey.kambalin@auriga.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=serg.oker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).